-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Hit Selection #6123
Automatic Hit Selection #6123
Conversation
c914ec8
to
3586d7f
Compare
1f891ad
to
9ebd3d1
Compare
} | ||
|
||
@Override | ||
public Map<String, List<GWTPropertyDescriptor>> previewFilterCriteriaColumns(@NotNull ExpProtocol protocol, List<String> columnNames) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of column names passed in assume that they are candidates for replicate stats (numeric measures). Does the list get filtered / validated on the client side, or is it possible to create replicate stats for a string field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me from me in terms of Lombok usage.
assay/src/org/labkey/assay/plate/AssayPlateMetadataServiceImpl.java
Outdated
Show resolved
Hide resolved
.stream() | ||
.filter(state -> !stateManager.isOperationPermitted(state, PlateDataStateManager.DataOperation.hitSelection)) | ||
.map(DataState::getRowId) | ||
.toList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably just get the set of the DataState
row IDs.
f0c379c
to
3ba10d9
Compare
6202ae9
to
d09c22b
Compare
Rationale
This introduces the capability for automatic plate-based assay result hit selection based on filter criteria. Filter criteria are specified on assay result domain properties and are subsequently utilized to filter upon assay results when inserted/updated to determine if any should be marked as hits.
Related Pull Requests
Changes
filterCriteria
to property descriptors and add CRUD support for themassay-filterCriteriaColumns.api
to assist with retreival of column metadata for columns that are/to be generatedassay.FilterCriteria
table@labkey/components