Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic Hit Selection #1649

Merged
merged 46 commits into from
Dec 19, 2024
Merged

Automatic Hit Selection #1649

merged 46 commits into from
Dec 19, 2024

Conversation

labkey-alan
Copy link
Contributor

@labkey-alan labkey-alan commented Nov 21, 2024 •
edited
Loading

Rationale

This PR adds the client side code necessary to configure automatic hit selection for plate based assays.

Related Pull Requests

Changes

  • Add HitCriteriaRenderer
  • Add HitCriteriaModal
  • Add useLoadableState
    • Helper hook that takes a loader method and returns loadingState, value, and error
  • AssayProtocolModel: Add hitCriteria
  • Render Hit Criteria components in AssayDesignerPanels

@labkey-alan labkey-alan self-assigned this Nov 21, 2024
@labkey-alan labkey-alan mentioned this pull request Nov 22, 2024
Closed
@labkey-alan labkey-alan marked this pull request as draft November 22, 2024 00:01
@labkey-nicka labkey-nicka mentioned this pull request Dec 4, 2024
Merged
@labkey-alan labkey-alan mentioned this pull request Dec 11, 2024
Merged
@labkey-alan labkey-alan force-pushed the fb_auto_hits branch 2 times, most recently from b6473e3 to 814b0d1 Compare December 17, 2024 18:40
labkey-alan and others added 20 commits December 18, 2024 11:12
@labkey-alan
Fix unique key warnings in domain designer
4b668b5
@labkey-alan
CLean up filter panel styles
c026642
@labkey-alan
Add HitCriteriaRenderer
07bc2b0
@labkey-alan
Add HitCriteriaModal and useLoadableState
27275cc
@labkey-alan
Render HitCriteria
2db3dd8 
- Render HitCriteriaModal
- Add AssayDomainForm, which allows us to memoize props
@labkey-alan
Update release notes
34a69e1
@labkey-alan
FilterExpressionView: memoize callbacks
6cbdf4d
@labkey-alan
AssayDesignerPanels: Fix issue with appDomainHeaders, fix tests
12c29dd
@labkey-alan
Cleanup
8a36111
@labkey-nicka @labkey-alan
Prevent serialization of "hitCriteria" (stop gap)
477abce
@labkey-alan
Bump @labkey/api
ec826a8
@labkey-alan
Add request util
27f15a3
@labkey-alan
Add getFilterCriteriaColumns to assay API wrapper
db6e8cc
@labkey-alan
Update AssayDesigner to assume filterCriteria is on DomainFields
3673d93
@labkey-alan
Remove protocolModel from FilterCriteriaContext
51cde56
@labkey-alan
Remove hack
c5525a5
@labkey-alan
FilterCriteriaModal - use propertyIds
647dc82
@labkey-alan
request: Add RequesstHandler
fa55e1b
@labkey-alan
Fix styling for FilterCriteriaRenderer
50474a1
@labkey-alan
Update filter criteria when field name changes
fcbae9b
@labkey-alan
FilterCriteriaRenderer: optionally render empty message
289cc78
@labkey-alan
Fix styling for hit-criteria-renderer
4523a5b
@labkey-alan
Fix styling for FilterCriteriaRenderer
1ea2733
@labkey-alan
Fix class names
639e6ed
@labkey-alan
FilterCriteriaModal: Add empty messages
8c31f1f 
Fix issue when there are no fields
@labkey-alan
AssayDesignerPanels: Fix issue with saveFilterCriteria
da1d015
@labkey-alan
FilterCriteriaModal: Give reference properties stable propertyId values
2eb323b
@labkey-alan
FilterCriteriaModal: filter fields to openTo and related
b25223c
@labkey-alan
DomainField.serialize - Don't change propertyId or referencePropertyI…
e661f82 
…d in filterCriteria
@labkey-alan
AssayPropertiesInput: Disable Edit Criteria button when plate metadat…
e592956 
…a is not enabled
@labkey-alan
AssayDesignerPanels: Hide field "edit criteria" buttons when plate me…
b6c08fa 
…tadata is disabled
@labkey-alan
FilterCriteriaModal.tsx: Fix issue with empty fields
b31be71
@labkey-alan
Bump api-js
3fe7883
@labkey-alan
request.ts - Fix types
f064bab
@labkey-alan
models.test.ts - Fix tests
ccc8319
@labkey-alan labkey-alan marked this pull request as ready for review December 18, 2024 18:13
@labkey-alan labkey-alan merged commit 4ff1ae9 into develop Dec 19, 2024
1 check passed
@labkey-alan labkey-alan deleted the fb_auto_hits branch December 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-nicka labkey-nicka labkey-nicka approved these changes

Assignees

@labkey-alan labkey-alan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-alan @labkey-nicka