Rework tutorials #161
Rework tutorials #161
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 81.21% 81.16% -0.06%
==========================================
Files 11 11
Lines 1219 1221 +2
==========================================
+ Hits 990 991 +1
- Misses 229 230 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks @thuiop , I'm taking a look at the notebooks separately
|
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2021-05-28T15:03:17Z IMO it might be a little annoying for the users to have this many images for a tutorial notebook - maybe we can add a flag to the plotting function so that it only plots the first few galaxies? thuiop commented on 2021-05-28T15:07:31Z Oh, we can just slice the blended_images if needed. ismael-mendoza commented on 2021-05-28T15:13:51Z Ah true, could you add that? Thanks :) |
|
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2021-05-28T15:03:18Z Again this thuiop commented on 2021-05-28T15:08:56Z Actually, it is not that annoying when running it with jupyter since the cell "collapses" when it becomes too long. Otherwise we would need to catch the errors and just count them ; we can also decide to not print the error at all.
ismael-mendoza commented on 2021-05-28T15:16:21Z oh OK I forgot about that. For the tutorial I think that it might be better to filter out the error completely and just make a note in the paragraph before the cell ismael-mendoza commented on 2021-05-28T15:17:26Z I think it's nice to avoid having errors printed out at least for the intro notebook (to avoid user confusion). thuiop commented on 2021-05-31T09:33:18Z You're right, I added a verbose parameter to the MetricsGenerator. |
|
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2021-05-28T15:03:19Z Line #5. target_meas={"ellipticity":btk.metrics.meas_ksb_ellipticity})
There is some weird indentation in this line thuiop commented on 2021-05-28T15:09:27Z Exact, I am not sure why thuiop commented on 2021-05-31T09:35:13Z Ok, it is just because reviewNB automatically goes to the next line while jupyter does not ; the last line is aligned with the first |
|
Oh, we can just slice the blended_images if needed. View entire conversation on ReviewNB |
|
Actually, it is not that annoying when running it with jupyter since the cell "collapses" when it becomes too long. Otherwise we would need to catch the errors and just count them ; we can also decide to not print the error at all.
View entire conversation on ReviewNB |
|
Exact, I am not sure why View entire conversation on ReviewNB |
|
Ah true, could you add that? Thanks :) View entire conversation on ReviewNB |
|
oh OK I forgot about that. For the tutorial I think that it might be better to filter out the error and just make a note in the paragraph before the cell View entire conversation on ReviewNB |
|
I think it's nice to avoid having errors printed out at least for the intro notebook (to avoid user confusion). View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2021-05-28T15:26:06Z Thanks this is a nice addition to demonstrate for users how to write their own sampling functions |
|
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2021-05-28T15:26:07Z Thanks to your helpful refactoring PR, now you can replace |
|
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2021-05-28T15:26:08Z Here too if you could slice the images to print less of them, that would be great |
|
View / edit / reply to this conversation on ReviewNB ismael-mendoza commented on 2021-05-28T15:26:09Z The I feel like this last sentence might be a bit ambiguous, since |
|
You're right, I added a verbose parameter to the MetricsGenerator. View entire conversation on ReviewNB |
|
Ok, it is just because reviewNB automatically goes to the next line while jupyter does not ; the last line is aligned with the first View entire conversation on ReviewNB |
|
I think we can merge now if you think it's ready @thuiop |
* First version * Close to complete version * Finished advanced-tutorials and corrected average precision * Adressed review comments * typo on which notebook has the advanced features * add note on how to pip install galsim_hub * whitespace * Added zeropoint airmass definition Co-authored-by: Ismael Mendoza <[email protected]>
I added a tutorial covering the "advanced" features of BTK, including multiresolution, writing your own sampling function/survey/measure function ...
It is near completion but should not be merged before #153, as it will have to be updated to reflect those changes.