Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize input and output #153

Closed
thuiop opened this issue May 20, 2021 · 0 comments · Fixed by #159
Closed

Normalize input and output #153

thuiop opened this issue May 20, 2021 · 0 comments · Fixed by #159
Assignees
Labels
bug Something isn't working refactor code refactoring
Milestone

Comments

@thuiop
Copy link
Collaborator

thuiop commented May 20, 2021

Now that the structure of BTK is mostly fixed, we should address some issues regarding the input and the outputs.

  • The output for multiple surveys is like blend_results["blend_images"]["LSST"] while the output for several measure functions is like measure_results["sep_measure0"]["deblended_images"]. I think we should swap the order for the surveys.
  • We should think about how to handle the case where only one survey/measure function/measure_kwargs is inputted. Right now, surveys must be given as a list, but does not take the "dictionary form" when there is only one survey. For measure functions, the input is always a list and the output is always a dictionary index by the names of the functions. For the measure_kwargs, the input is a list (or None) and the output adds numbers to the end of the measure function name (hence the "sep_measure0"), even when the input is None or a list of length one. I personally feel that the best would be to have the possibility to give a single element and get the results in the "simple form", or give a list of elements and get the results in the "dictionary form" ; for the measure_kwargs this would mean not adding the zero in the name ; it would add some code though to do all the checks though.
  • As pointed in Do we need both meas_bands in DrawBlendGenerator and meas_band_num in MetricsGenerator? #152 , the meas_bands are not really handled correctly right now
  • There may be other redundant/useless parameters
@thuiop thuiop added bug Something isn't working refactor code refactoring labels May 20, 2021
@thuiop thuiop added this to the v1.0.0 milestone May 20, 2021
@thuiop thuiop self-assigned this May 20, 2021
This was referenced May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor code refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant