Feature/crkrenn/best candidate sampling #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@crkrenn -- @jwhite242 and I were talking and we think that these (and #271) would be useful for a sampling section right after the parameter documentation Jeremy just got done writing. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jsemler @FrankD412,
I've implemented a "best candidate" sampling method based on coding by Cody Raskin (@antimatterhorn). See https://bl.ocks.org/mbostock/6224396 for a related visualization.
I've put this in a separate pull request because it requires pandas, numpy, & scipy packages to run.
What is your advice regarding the extra packages? I've installed them in my own venv, and the best candidate sampling code works. But unless I modify requirements.txt, the sampling code won't work out of the box for other users.
-Chris