Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/crkrenn/multidimensional sampling #271

Closed

Conversation

crkrenn
Copy link
Contributor

@crkrenn crkrenn commented May 19, 2020

I've implemented three "NTNF" style sampling interfaces.

Because this is of general interest and can be implemented in maestro alone, I am submitting it here.

Best_candidate sampling is next.

@crkrenn
Copy link
Contributor Author

crkrenn commented May 19, 2020

This pull request reemphasizes my interest in passing maestro options via the yaml file. Then, we can type maestro run spec instead of maestro run spec --pgen {{one_of_my_pgen_files_I_can_not_remember_which_one}} --autoyes

Pretty please?

AUTOYES: True
PGEN: ./pgen_sample.py

@FrankD412
Copy link
Member

I'm wondering if these don't belong in samples -- I'm thinking they might either belong in documentation or in a folder on their own. @jwhite242 is writing some pgen documentation, might it belong there?

@FrankD412
Copy link
Member

This pull request reemphasizes my interest in passing maestro options via the yaml file. Then, we can type maestro run spec instead of maestro run spec --pgen {{one_of_my_pgen_files_I_can_not_remember_which_one}} --autoyes

Pretty please?

AUTOYES: True
PGEN: ./pgen_sample.py

So, I've been considering a different but it doesn't feel right to place those settings into the specification itself. They are not required to actually run the study, and are optional. I've been tossing around the idea of using a smaller spec that could list specs with their command line options. A sort of maestro play feature. You could then spin off multiple studies.

This was referenced May 23, 2020
@crkrenn
Copy link
Contributor Author

crkrenn commented Jun 2, 2020

@FrankD412 & @jsemler, what do you think of a maestro_config.yaml file like the one that Brian D. has been talking about in his work with Jessica?

@crkrenn
Copy link
Contributor Author

crkrenn commented Jun 2, 2020

@FrankD412 (cc @jsemler), I want to help you keep your code base clean and maintainable. I'd also like a place to hang my sampling code, and associating it with maestro seems to be the right choice because it only depends on maestro (and some public third-party packages).

Could a third-party directory or LLNL/maestro-examples repo be appropriate?

See the following links for precedent:

https://github.com/gramps-project
https://www.gramps-project.org/wiki/index.php/Addons_development

@FrankD412
Copy link
Member

@crkrenn -- I've been meaning to collaborate with users on an example directory. These might be a good start there, I also think they might be good here for advanced documentation. I'm feeling 50/50 on it -- @jwhite242 @jsemler, thoughts?

@crkrenn
Copy link
Contributor Author

crkrenn commented Jun 2, 2020 via email

@FrankD412
Copy link
Member

@ckrenn -- Makes sense. I will look into what's needed to start a new repository of examples and get back to you. In the mean time we can keep this PR open to keep track. Thanks!

@FrankD412
Copy link
Member

@crkrenn -- I've started an example repository. Please submit a PR to the collection of examples here.

@FrankD412
Copy link
Member

@crkrenn -- do you mind if I close this PR and the other sampling PR since they're now up on the sheetmusic repository?

@crkrenn crkrenn closed this Jun 20, 2020
@crkrenn crkrenn deleted the feature/crkrenn/multidimensional_sampling branch June 20, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants