Feature/merge to release #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added CW dashboard * use module output for SSM param
* fixed error * fix error
…ing-search-api" This reverts commit 339d301, reversing changes made to cf0159b.
This reverts commit cf0159b.
This reverts commit 69f433b.
* added Terraform Comliance checks * added staging and prod checks
* comment tests out * comment tests out to fix error * add tests * fix syntax error * update tests
* comment out all tests except 1 * remove branch filter to test * test * test * fix test * re-added test * re-added test * re-added test * re-added test * re-added test * re-added test * re-added test * fix tests * add filter back
Account api gsi reversal
vpc changed in terraform
Account api gsi reversal v2
updating the package version
Update CODEOWNERS
* Add based implementation for GetTransactionList endpoint. * Add SearchTransactions endpoint. Move all logic from financial-transactions-api * Remove unnesessary enters * Fix formattin issues * One more try to fix formatting * Delete setters from transactions-related properties. Use the static factory method approach instead. * Fix formatting. * Change access layor for response models * Add E2E tests for TransactionsSearch endpoint * Fix formatting issues * Add unit tests for transactions controller * Rename Person model to Sender * Fix search terms. Rename from person to sender * Fix integration tests * Change port number to 5003 to resolve local conflicts between APIs
Housing finance search with Deep Pagination
* Rename Person model to Sender * Update Hackney.Shared.HousingSearch package version
* FIxed Housing Finance Transaction Search * Add more logging for errors Co-authored-by: Sandip <Sandip@DESKTOP-8GSTDPG> Co-authored-by: golosowa.anna <[email protected]>
* Implement transactions filtering by start and end dates. * Fix e2e tests. * Add CreatedAt and LastUpdatedAt fields to the transactions model * Try to add api-nuget-token-context * Fix unit tests. Exclude comparation for LastUpdatedBy and CreatedBy fields * Remove createdAt and updatedAt from the response payload * Rename variables to much naming convention
amidomichael
requested review from
MirelaGeorgiou,
LBHMKeyworth,
rashmishetty1011 and
LBHSPreston
as code owners
mikemoody-amido
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
Add a link to the JIRA ticket that the changes in this PR describe.
Describe this PR
What is the problem we're trying to solve
Add a summary of the problem and any additional context that helps explain what the issue we're trying to solve is.
What changes have we introduced
Add descriptions of what changes were made to address the problem and provide a solution.
Include any links to commits that introduce significant additions of code if they help explain the process of coming to the solution. e.g Addition of test database setup, addition of first test and production class, removal of buggy code, etc.
Checklist
Follow up actions after merging PR
Are there any next steps that need to addressed after merging this PR? Add them here.