change to use regional API gateway endpoint #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charnjitsohal1
requested review from
MirelaGeorgiou,
LBHMKeyworth,
rashmishetty1011 and
LBHSPreston
as code owners
MirelaGeorgiou
approved these changes
Nov 8, 2021
mikemoody-amido
added a commit
that referenced
this pull request
Nov 18, 2021
* WIP: Consume Nuget package * Consume NuGet package * Solved issue with tests * Updated package * added CW dashboard (#62) * added CW dashboard * use module output for SSM param * Fix error (#64) * fixed error * fix error * increase node count to fix yellow status (#66) * increased instance count for staging (#67) * Updated package * change to use regional API gateway endpoint (#70) * revert change to regional api (#71) * Account Elastic Search * rebase from master * Revert "Merge branch 'master' of https://github.com/LBHackney-IT/housing-search-api" This reverts commit 339d301, reversing changes made to cf0159b. * Revert "rebase from master" This reverts commit cf0159b. * Revert "Account Elastic Search" This reverts commit 69f433b. * revert to edge endpoint (#72) * added Terraform Compliance checks (#75) * added Terraform Comliance checks * added staging and prod checks * Fix test (#76) * comment tests out * comment tests out to fix error * add tests * fix syntax error * update tests * comment out all tests except 1 (#77) * comment out all tests except 1 * remove branch filter to test * test * test * fix test * re-added test * re-added test * re-added test * re-added test * re-added test * re-added test * re-added test * fix tests * add filter back * fixed error (#78) Co-authored-by: humulla <[email protected]> Co-authored-by: Charnjit Sohal <[email protected]> Co-authored-by: Evangelos Aktoudianakis <[email protected]> Co-authored-by: Evangelos Aktoudianakis <[email protected]> Co-authored-by: Hamid Jolany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/MTTL-1870
Describe this PR
What is the problem we're trying to solve
WAF requires regional api gateway endpoint
What changes have we introduced
Change serverless.yml to use regional api gateway endpoint
Include any links to commits that introduce significant additions of code if they help explain the process of coming to the solution. e.g Addition of test database setup, addition of first test and production class, removal of buggy code, etc.
Checklist
Follow up actions after merging PR
Are there any next steps that need to addressed after merging this PR? Add them here.