Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AppConfiguration, Deploy, and Job models #451

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Aug 9, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add AppConfiguration, Deploy, and Job models

Which issue(s) this PR fixes:

Fixes #370 #374

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 5807510372

  • 119 of 354 (33.62%) changed or added relevant lines in 8 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.0%) to 70.557%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generators/job_generator.go 59 74 79.73%
pkg/generator/appconfiguration/generators/app_configuration_generator.go 0 24 0.0%
pkg/cmd/spec/generator.go 0 27 0.0%
pkg/generator/appconfiguration/generators/namespace_generator.go 0 28 0.0%
pkg/generator/appconfiguration/generators/components_generator.go 0 31 0.0%
pkg/generator/appconfiguration/generators/util.go 59 106 55.66%
pkg/generator/appconfiguration/generators/deployment_generator.go 0 63 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 71.92%
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 5780726001: -2.0%
Covered Lines: 5217
Relevant Lines: 7394

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 4d2c49c into KusionStack:main Aug 9, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model: Support AppConfiguration model
5 participants