Feature: Add AppConfiguration, Deploy and Job models #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotxx
added
the
kind/feature
elliotxx
requested review from
SparkYuan,
ffforest,
panshuai111,
healthjyk,
adohe and
liu-hm19
Pull Request Test Coverage Report for Build 5749095691
💛 - Coveralls |
elliotxx
changed the title
SparkYuan
changed the title
SparkYuan
changed the title
# Conflicts: # pkg/cmd/spec/generator.go # pkg/cmd/spec/generator_test.go # pkg/engine/operation/destory_test.go # pkg/engine/operation/graph/resource_node_test.go # pkg/engine/operation/preview_test.go # pkg/engine/operation/watch_test.go # pkg/generator/kcl/kcl_generator_test.go
SparkYuan
force-pushed
the
feat/app-config
branch
from
db6ded1 to
932c227
Compare
|
clean commit logs and fix ut coverage report in #451 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
fix #370 #374
What this PR does / why we need it:
Add AppConfiguration, Deploy and Job models