Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch size #318

Merged
merged 1 commit into from
May 13, 2024
Merged

Batch size #318

merged 1 commit into from
May 13, 2024

Conversation

alexsnaps
Copy link
Member

Based off #317

@alexsnaps alexsnaps changed the base branch from main to absolute_ts May 8, 2024 23:15
@alexsnaps alexsnaps mentioned this pull request May 9, 2024
Merged
Base automatically changed from absolute_ts to main May 10, 2024 11:56
@alexsnaps alexsnaps marked this pull request as ready for review May 10, 2024 11:59
adam-cattermole
adam-cattermole reviewed May 10, 2024
View reviewed changes
Copy link
Member

@adam-cattermole adam-cattermole left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the doc as well.. remove the old ttl vars and add this batch size one https://github.com/Kuadrant/limitador/blob/main/doc/server/configuration.md?plain=1#L216-L232, https://github.com/Kuadrant/limitador/blob/main/doc/server/configuration.md?plain=1#L385-L400

Looks good otherwise

limitador-server/src/main.rs Show resolved Hide resolved
@alexsnaps alexsnaps mentioned this pull request May 13, 2024
Merged
adam-cattermole
adam-cattermole approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, given the docs are already out of date we can update in a follow up if preferred

didierofrivia
didierofrivia approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@alexsnaps alexsnaps merged commit 25346a6 into main May 13, 2024
20 checks passed
@alexsnaps alexsnaps deleted the batch_size branch May 13, 2024 13:34
@KevFan KevFan mentioned this pull request May 14, 2024
Merged
@eguzki eguzki mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-cattermole adam-cattermole adam-cattermole approved these changes

@didierofrivia didierofrivia didierofrivia approved these changes

@eguzki eguzki Awaiting requested review from eguzki

Assignees
No one assigned
Labels
enhancement
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexsnaps @didierofrivia @adam-cattermole @eguzki