Use absolute timestamps when dealing with expiry from Redis #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
commented
May 8, 2024
| end | ||
| table.insert(res, redis.call('pexpiretime', counter_key)) |
There was a problem hiding this comment.
This isn't ideal, as pexpiretime was introduced in Redis 7... that being said, elasticache supports it
There was a problem hiding this comment.
Not that it matters right now but it's also supported by memorystore and I think Azure cache
Merged
| (Instant::now() - time_start_update_counters).as_millis() as u64 | ||
| ), | ||
| ); | ||
| cached_counters.apply_remote_delta(counter, new_value, remote_deltas, ttl); |
There was a problem hiding this comment.
nit: maybe we should also change this ttl to expires_at
adam-cattermole
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.