Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/docs #225

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Maintenance/docs #225

merged 3 commits into from
Dec 4, 2023

Conversation

Boomatang
Copy link
Contributor

  • Update docs for better rendering of dos.kaudrant.io
  • fix broken links

Verification

  • Edited markdown pages should render correctly in
    • Github
    • Docs.kuadrant,io
  • All links should work in both locations

To help with rendering these changes on the docs site, Kuadrant/docs.kuadrant.io#41 can be used to run these changes locally

The links for fixed rendering on docs.kuadrant.io
This guide was missing form docs.kuadrant.io
Some edits done to get page to render correctly
@Boomatang Boomatang marked this pull request as ready for review November 20, 2023 09:29
@grzpiotrowski
Copy link
Contributor

Verified by running mkdocs locally and checked on GH and the changes look good to me.

There's one more broken link I noticed in doc/topologies.md which we could include maybe?

I think this is a working url to the mentioned tutorial: https://docs.redis.com/latest/rs/databases/active-active/get-started/

@grzpiotrowski grzpiotrowski self-requested a review December 4, 2023 11:32
Copy link
Contributor

@grzpiotrowski grzpiotrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Boomatang Boomatang merged commit adff831 into Kuadrant:main Dec 4, 2023
9 checks passed
@Boomatang Boomatang deleted the maintenance/docs branch December 4, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants