Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken links and render issues #41

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

Boomatang
Copy link
Contributor

@Boomatang Boomatang commented Nov 10, 2023

All commits Prefix are to help validate chances in the external repos. Those commits before final merge.

To verify this PR check the listed pages for correct renders and valid links.

This PR does not change the contents of the pages.

Related PRs

Pages updated by changes in this repo

Pages with external updates

mkdocs.yml Outdated
@@ -166,6 +167,7 @@ nav:
- 'Topologies': limitador/doc/topologies.md
- 'Server':
- 'Overview': limitador/limitador-server/README.md
- 'Kuberbetes': limitador/limitador-server/kubernetes/README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'Kuberbetes': limitador/limitador-server/kubernetes/README.md
- 'Kubernetes': limitador/limitador-server/kubernetes/README.md

@grzpiotrowski
Copy link

grzpiotrowski commented Nov 29, 2023

Something for this PR:
Spotted this link not working: How-to Guides -> Rate Limiting -> RateLimitPolicy for Application Developers

Should be: kuadrant-operator/doc/user-guides/simple-rl-for-app-developers.md
instead of: multicluster-gateway-controller/docs/how-to/simple-ratelimitpolicy-for-app-developers.md

And then I believe that:
multicluster-gateway-controller/docs/how-to/simple-ratelimitpolicy-for-app-developers.md

Should be added in How-to Guides -> Multicluster Gateway Controller section.

@Boomatang
Copy link
Contributor Author

fyi; @grzpiotrowski and I had a conversion on his comments and while we believe there is something that needs to be done, this PR is not the correct place to do it. As a group there needs to be a decision made on how guides for multi cluster and single cluster are displayed.

@grzpiotrowski
Copy link

/lgtm

Copy link

@grzpiotrowski grzpiotrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@Boomatang
Copy link
Contributor Author

@guicassolato any chance you can approve this? @grzpiotrowski has looked at it but is not in the approvers list.

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Boomatang, grzpiotrowski, guicassolato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 50642d8 into Kuadrant:main Dec 11, 2023
2 checks passed
@Boomatang Boomatang deleted the maintenance branch December 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants