-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing broken links and render issues #41
Conversation
mkdocs.yml
Outdated
@@ -166,6 +167,7 @@ nav: | |||
- 'Topologies': limitador/doc/topologies.md | |||
- 'Server': | |||
- 'Overview': limitador/limitador-server/README.md | |||
- 'Kuberbetes': limitador/limitador-server/kubernetes/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 'Kuberbetes': limitador/limitador-server/kubernetes/README.md | |
- 'Kubernetes': limitador/limitador-server/kubernetes/README.md |
Something for this PR: Should be: And then I believe that: Should be added in How-to Guides -> Multicluster Gateway Controller section. |
fyi; @grzpiotrowski and I had a conversion on his comments and while we believe there is something that needs to be done, this PR is not the correct place to do it. As a group there needs to be a decision made on how guides for multi cluster and single cluster are displayed. |
5e38bd6
to
8019057
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
@guicassolato any chance you can approve this? @grzpiotrowski has looked at it but is not in the approvers list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Boomatang, grzpiotrowski, guicassolato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All commits Prefix are to help validate chances in the external repos. Those commits before final merge.
To verify this PR check the listed pages for correct renders and valid links.
This PR does not change the contents of the pages.
Related PRs
Pages updated by changes in this repo
Pages with external updates