Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for a listener with no hostname set #908

Merged
merged 1 commit into from
Oct 4, 2024
Merged

allow for a listener with no hostname set #908

merged 1 commit into from
Oct 4, 2024

Conversation

maleck13
Copy link
Collaborator

@maleck13 maleck13 commented Oct 4, 2024

fixes #905

Signed-off-by: craig [email protected]

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

@mikenairn

@maleck13 maleck13 requested a review from mikenairn October 4, 2024 08:33
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.32%. Comparing base (ece13e8) to head (4c79567).
Report is 217 commits behind head on main.

Files with missing lines Patch % Lines
controllers/dnspolicy_dnsrecords.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   80.20%   81.32%   +1.11%     
==========================================
  Files          64       90      +26     
  Lines        4492     7031    +2539     
==========================================
+ Hits         3603     5718    +2115     
- Misses        600      891     +291     
- Partials      289      422     +133     
Flag Coverage Δ
bare-k8s-integration 7.85% <0.00%> (?)
controllers-integration 73.06% <0.00%> (?)
envoygateway-integration 50.12% <0.00%> (?)
gatewayapi-integration 13.02% <0.00%> (?)
integration ?
istio-integration 53.80% <0.00%> (?)
unit 28.82% <0.00%> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.90% <100.00%> (+19.48%) ⬆️
api/v1beta2 (u) 81.25% <75.17%> (-10.18%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 71.51% <ø> (-2.40%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 85.89% <ø> (+6.43%) ⬆️
controllers (i) 82.66% <82.41%> (+5.86%) ⬆️
Files with missing lines Coverage Δ
controllers/dnspolicy_dnsrecords.go 63.88% <0.00%> (-1.80%) ⬇️

... and 50 files with indirect coverage changes

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@maleck13 maleck13 merged commit d838ca2 into main Oct 4, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: dnspolicy record controller panics if no name on listener
2 participants