Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: dnspolicy record controller panics if no name on listener #905

Closed
maleck13 opened this issue Oct 3, 2024 · 0 comments · Fixed by #908
Closed

bug: dnspolicy record controller panics if no name on listener #905

maleck13 opened this issue Oct 3, 2024 · 0 comments · Fixed by #908
Assignees

Comments

@maleck13
Copy link
Collaborator

maleck13 commented Oct 3, 2024

create a gateway with a listener that has no hostname
DNSPolicy will not get reconciled as it hits a nil pointer

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager panic: runtime error: invalid memory address or nil pointer dereference
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x15995dc]
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager goroutine 661 [running]:
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:111 +0x1a4
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager panic({0x183a240?, 0x2fee490?})
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager /usr/local/go/src/runtime/panic.go:770 +0x124
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager github.com/kuadrant/kuadrant-operator/controllers.(*DNSPolicyReconciler).reconcileGatewayDNSRecords(0x400065ba10, {0x1e9bad8, 0x4000b04600}, 0x40004af380, 0x40004ae000)
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager /workspace/controllers/dnspolicy_dnsrecords.go:60 +0x23c
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager github.com/kuadrant/kuadrant-operator/controllers.(*DNSPolicyReconciler).reconcileDNSRecords(0x400065ba10, {0x1e9bad8, 0x4000b04600}, 0x40004ae000, 0x40007dc4b0)
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager /workspace/controllers/dnspolicy_dnsrecords.go:38 +0x424
kuadrant-operator-controller-manager-8566585ffc-gqr66 manager github.com/kuadrant/kuadrant-operator/controllers.(*DNSPolicyReco

@maleck13 maleck13 added this to Kuadrant Oct 3, 2024
@maleck13 maleck13 self-assigned this Oct 3, 2024
@maleck13 maleck13 converted this from a draft issue Oct 3, 2024
@maleck13 maleck13 moved this from In Progress to Ready For Review in Kuadrant Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant