Runtime istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 #785

eguzki · 2024-07-26T15:12:42Z

Golang istio.io/istio deps upgraded to 1.22.3

It is required because golang envoygateway 1.1 dep conflicts on github.com/envoyproxy/go-control-plane/envoy/extensions/injected_credentials/generic/v3 package

istio.io/istio 1.20.0 requires a package from github.com/envoyproxy/go-control-plane in 0.12.0 that does not exist when github.com/envoyproxy/go-control-plane is upgraded to 0.12.1 due to envoygateway 1.1

Golang istio.io/istio deps upgraded to 1.22.3 It is required because golang envoygateway 1.1 dep conflicts on github.com/envoyproxy/go-control-plane/envoy/extensions/injected_credentials/generic/v3 package istio.io/istio 1.20.0 requires a package from github.com/envoyproxy/go-control-plane in 0.12.0 that does not exist when github.com/envoyproxy/go-control-plane is upgraded to 0.12.1 due to envoygateway 1.1 Signed-off-by: Eguzki Astiz Lezaun <[email protected]>

eguzki · 2024-07-26T15:14:23Z

controllers/rate_limiting_envoygateway_envoyextensionpolicy_controller.go

+// For more details, check Reconcile and its Result here:
+// - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/reconcile
+func (r *RateLimitingEnvoyExtensionPolicyReconciler) Reconcile(eventCtx context.Context, req ctrl.Request) (ctrl.Result, error) {
+	a := &egv1alpha1.EnvoyExtensionPolicy{}


This is just for adding a real package import, which affects how deps are organized in go.mod

eguzki · 2024-07-26T15:16:23Z

passing tests means that our operator having golang deps on istio 1.22.3 works well with the runtime version of istio being 1.20.8 (the expected one for OSSM 2.6)

codecov · 2024-07-26T15:17:10Z

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (envoygateway@f975e2d). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff               @@
##             envoygateway     #785   +/-   ##
===============================================
  Coverage                ?   82.35%           
===============================================
  Files                   ?       78           
  Lines                   ?     6131           
  Branches                ?        0           
===============================================
  Hits                    ?     5049           
  Misses                  ?      722           
  Partials                ?      360

Flag	Coverage Δ
bare-k8s-integration	`4.47% <0.00%> (?)`
controllers-integration	`71.99% <0.00%> (?)`
gatewayapi-integration	`10.76% <0.00%> (?)`
istio-integration	`55.85% <0.00%> (?)`
unit	`31.82% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	`71.42% <0.00%> (?)`
api/v1beta2 (u)	`90.39% <0.00%> (?)`
pkg/common (u)	`88.13% <0.00%> (?)`
pkg/istio (u)	`72.50% <0.00%> (?)`
pkg/log (u)	`94.73% <0.00%> (?)`
pkg/reconcilers (u)	`∅ <0.00%> (?)`
pkg/rlptools (u)	`83.64% <0.00%> (?)`
controllers (i)	`82.06% <0.00%> (?)`

Files	Coverage Δ
...ng_envoygateway_envoyextensionpolicy_controller.go	`0.00% <0.00%> (ø)`

adam-cattermole · 2024-07-26T15:27:28Z

go.mod

@@ -1,72 +1,73 @@
 module github.com/kuadrant/kuadrant-operator

-go 1.22.0
+go 1.22.5


Interesting that envoyproxy/gateway explicitly has .5 in their go.mod for v1.1

adam-cattermole

Looks good to me

adam-cattermole · 2024-07-29T09:52:14Z

I'm in need of these changes for the authpolicy branch (#737) now that the envoygateway branch has been rebased to gwapi v1.1. I hope you do not mind but I'm going to merge this to rebase and finish up the next draft of my PR.

…#785) * deployed istio updated to 1.20.8 (ossm 2.6) Golang istio.io/istio deps upgraded to 1.22.3 It is required because golang envoygateway 1.1 dep conflicts on github.com/envoyproxy/go-control-plane/envoy/extensions/injected_credentials/generic/v3 package istio.io/istio 1.20.0 requires a package from github.com/envoyproxy/go-control-plane in 0.12.0 that does not exist when github.com/envoyproxy/go-control-plane is upgraded to 0.12.1 due to envoygateway 1.1 Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * updated manifests --------- Signed-off-by: Eguzki Astiz Lezaun <[email protected]>

* envoygateway dev environment install (#678) * envoygateway dev environment install * egctl on detected os and arch * Makefile: pulling out os and arch Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * development environment: envoygateway v1.1.0 (#778) Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * Runtime istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 (#785) * deployed istio updated to 1.20.8 (ossm 2.6) Golang istio.io/istio deps upgraded to 1.22.3 It is required because golang envoygateway 1.1 dep conflicts on github.com/envoyproxy/go-control-plane/envoy/extensions/injected_credentials/generic/v3 package istio.io/istio 1.20.0 requires a package from github.com/envoyproxy/go-control-plane in 0.12.0 that does not exist when github.com/envoyproxy/go-control-plane is upgraded to 0.12.1 due to envoygateway 1.1 Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * updated manifests --------- Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * Envoy Gateway AuthPolicy (#737) * Enable envoygateway integration tests Signed-off-by: Adam Cattermole <[email protected]> * Add egapiv1 to scheme Signed-off-by: Adam Cattermole <[email protected]> * Fix lint issues Signed-off-by: Adam Cattermole <[email protected]> * Add envoy SecurityPolicy controller Signed-off-by: Adam Cattermole <[email protected]> * Add envoy ReferenceGrant controller Signed-off-by: Adam Cattermole <[email protected]> * Update manifests and bundle Signed-off-by: Adam Cattermole <[email protected]> * Update envoy gatewayclass to match GATEWAYAPI_PROVIDER name Signed-off-by: Adam Cattermole <[email protected]> * Set gateway class in tests from provider Signed-off-by: Adam Cattermole <[email protected]> * Enable new controllers in integration tests Signed-off-by: Adam Cattermole <[email protected]> * Add policy target object tracking to topology index Signed-off-by: Adam Cattermole <[email protected]> * Add istio AuthorizationPolicy controller Signed-off-by: Adam Cattermole <[email protected]> * Prepare for envoygateway integration tests Signed-off-by: Adam Cattermole <[email protected]> * Generify for integration tests Signed-off-by: Adam Cattermole <[email protected]> * Add envoygateway auth integration tests Signed-off-by: Adam Cattermole <[email protected]> * Do not set GATEWAYAPI_PROVIDER for tests that do not use it Signed-off-by: Adam Cattermole <[email protected]> * Set owner references in new controllers Signed-off-by: Adam Cattermole <[email protected]> * Enable security policy deletion tests Signed-off-by: Adam Cattermole <[email protected]> * Shorten github workflow integration test names Signed-off-by: Adam Cattermole <[email protected]> * Refactor SecurityPolicy controller For Kuadrants Signed-off-by: Adam Cattermole <[email protected]> * Update deletion logic Signed-off-by: Adam Cattermole <[email protected]> * Use new PolicyType Signed-off-by: Adam Cattermole <[email protected]> * test: Explicitly set parentRef gateway namespace Signed-off-by: Adam Cattermole <[email protected]> --------- Signed-off-by: Adam Cattermole <[email protected]> * envoygateway kuadrant status controller check added (#847) Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * Envoygateway wasm controller (#848) * envoygateway controllers to setup wasm module Limitador cluster controller based on EnvoyPatchPolicy Wasm controller based on EnvoyExtensionPolicy Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * envoygateway: enable envoypatchpolicy Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * envoygateway: wasm module tests Signed-off-by: Eguzki Astiz Lezaun <[email protected]> --------- Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * fix lint issues Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * bundle/manifests/kuadrant-operator.clusterserviceversion.yaml: autogeneration update Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * go.[mod|sum] updated Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * envoygateway: doc Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * Provider agnostic gateway name/namespace (#771) * Provider agnostic gateway name/namespace Signed-off-by: Adam Cattermole <[email protected]> * Update docs gateway name/namespace Signed-off-by: Adam Cattermole <[email protected]> * Use istio/envoy-gateway for provider namespace Signed-off-by: Adam Cattermole <[email protected]> * Use EG_NAMESPACE when patching Signed-off-by: Adam Cattermole <[email protected]> --------- Signed-off-by: Adam Cattermole <[email protected]> * Update doc/install/install-kubernetes.md Co-authored-by: Adam Cattermole <[email protected]> Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * Update doc/install/install-kubernetes.md Co-authored-by: Adam Cattermole <[email protected]> Signed-off-by: Eguzki Astiz Lezaun <[email protected]> --------- Signed-off-by: Eguzki Astiz Lezaun <[email protected]> Signed-off-by: Adam Cattermole <[email protected]> Co-authored-by: Adam Cattermole <[email protected]>

eguzki requested a review from a team as a code owner July 26, 2024 15:12

eguzki requested a review from adam-cattermole July 26, 2024 15:13

updated manifests

b24547a

eguzki commented Jul 26, 2024

View reviewed changes

eguzki changed the title ~~Deployed istio updated to 1.20.8 (ossm 2.6)~~ Deployed istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 Jul 26, 2024

eguzki changed the title ~~Deployed istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3~~ Runtime istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 Jul 26, 2024

adam-cattermole reviewed Jul 26, 2024

View reviewed changes

adam-cattermole approved these changes Jul 26, 2024

View reviewed changes

adam-cattermole merged commit cdad5ee into envoygateway Jul 29, 2024
18 of 19 checks passed

eguzki deleted the envoygateway-ratelimiting branch August 20, 2024 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Runtime istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 #785

Runtime istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 #785

eguzki commented Jul 26, 2024

eguzki Jul 26, 2024

eguzki commented Jul 26, 2024

codecov bot commented Jul 26, 2024 •

edited

Loading

adam-cattermole Jul 26, 2024

adam-cattermole left a comment

adam-cattermole commented Jul 29, 2024

Runtime istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 #785

Runtime istio updated to 1.20.8 (ossm 2.6) and Istio go dep to 1.22.3 #785

Conversation

eguzki commented Jul 26, 2024

eguzki Jul 26, 2024

Choose a reason for hiding this comment

eguzki commented Jul 26, 2024

codecov bot commented Jul 26, 2024 • edited Loading

Codecov Report

adam-cattermole Jul 26, 2024

Choose a reason for hiding this comment

adam-cattermole left a comment

Choose a reason for hiding this comment

adam-cattermole commented Jul 29, 2024

codecov bot commented Jul 26, 2024 •

edited

Loading