Provider agnostic gateway name/namespace

[adam-cattermole]

Changes

Builds on top of the authpolicy branch which should be merged first

• Renamed the gateway we deploy to kuadrant-ingressgateway for both istio and envoygateway
• Updated the namespace from istio-system/envoy-gateway-system to be gateway-system for both providers
• Updated the docs that refer to the gateway to point to this single gateway

Open to suggestions for the naming above, happy to change.

These changes makes it so that a user can follow the user-guides directly without amendment regardless of which gateway api provider they provision with (make local-setup GATEWAYAPI_PROVIDER=istio/make local-setup GATEWAYAPI_PROVIDER=envoygateway)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (envoygateway@9d29fcc). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff               @@
##             envoygateway     #771   +/-   ##
===============================================
  Coverage                ?   81.96%           
===============================================
  Files                   ?       86           
  Lines                   ?     6638           
  Branches                ?        0           
===============================================
  Hits                    ?     5441           
  Misses                  ?      812           
  Partials                ?      385           

Flag	Coverage Δ
bare-k8s-integration	4.99% <ø> (?)
controllers-integration	73.57% <ø> (?)
envoygateway-integration	37.68% <ø> (?)
gatewayapi-integration	11.07% <ø> (?)
istio-integration	53.52% <ø> (?)
unit	29.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	71.42% <0.00%> (?)
api/v1beta2 (u)	85.35% <0.00%> (?)
pkg/common (u)	88.13% <0.00%> (?)
pkg/istio (u)	71.11% <0.00%> (?)
pkg/log (u)	94.73% <0.00%> (?)
pkg/reconcilers (u)	∅ <0.00%> (?)
pkg/rlptools (u)	84.27% <0.00%> (?)
controllers (i)	83.32% <0.00%> (?)

[eguzki]

What about sticking to the gateway providers specific namespace names, i.e. istio-system and envoy-gateway-system and create a new namespace for the default ingress gateway in a provider agnostic namespacedname? Something like gateway-system/ingressgateway ?? I have the feeling that changing from istio-system to something else might raise issues

[maleck13]

@adam-cattermole we keeping this PR?

[adam-cattermole]

@maleck13 Yep, it's just a little out of date as it's based on the envoy gateway authpolicy branch which is yet to be merged

[eguzki]

Sweet 🍻