-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy limitador authorino and kuadrant-controller #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing...
After make kind-create-kuadrant-cluster
, because the image exported is quay.io/kuadrant/kuadrant-operator:dev
, the following uncommitted change remains:
diff --git a/config/manager/kustomization.yaml b/config/manager/kustomization.yaml
index b038c37..2550fb7 100644
--- a/config/manager/kustomization.yaml
+++ b/config/manager/kustomization.yaml
@@ -13,4 +13,4 @@ kind: Kustomization
images:
- name: controller
newName: quay.io/kuadrant/kuadrant-operator
- newTag: latest
+ newTag: dev
Maybe the deploy
target could roll back the image tag to the default latest
after kustomize build
?
deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config.
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
$(KUSTOMIZE) build config/deploy | kubectl apply -f -
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMAGE_TAG_BASE}:latest
Thanks for the tip! I will add the image restore statement |
cd26c6f
to
4e20f82
Compare
What
Fixes Kuadrant/kuadrant-controller#148
Verification Steps
wait until kuadrant CR status reports it is ready
Check limitador, authorino and the kuadrant controller are running in the namespace where the kuadrant CR was deployed
Check that the CRDs have also been deployed:
Dev Notes: