Wait until Deployment Status Ready

[guicassolato]

Closes #63

Verification steps

Deploy this branch:

kind create cluster --name authorino
make docker-build OPERATOR_IMAGE=authorino-operator:local
kind load docker-image authorino-operator:local --name authorino
kubectl create namespace authorino-operator
make install deploy OPERATOR_IMAGE=authorino-operator:localmake install deploy OPERATOR_IMAGE=authorino-operator:local

Create an Authorino instance whose Deployment will fail:

kubectl apply -f -<<EOF
apiVersion: operator.authorino.kuadrant.io/v1beta1
kind: Authorino
metadata:
  name: authorino
spec:
  clusterWide: true
  image: authorino:wrong
  listener:
    tls:
      enabled: false
  oidcServer:
    tls:
      enabled: false
EOF

Check the status of the Authorino CR:

kubectl get authorino/authorino -o jsonpath='{.status.conditions}'
# [{"lastTransitionTime":"2022-05-26T16:11:27Z","message":"Authorino Deployment resource not ready","reason":"DeploymentNotReady","status":"False","type":"Ready"}]

Fix the Deployment:

kubectl apply -f -<<EOF
apiVersion: operator.authorino.kuadrant.io/v1beta1
kind: Authorino
metadata:
  name: authorino
spec:
  clusterWide: true
  image: quay.io/kuadrant/authorino:latest
  listener:
    tls:
      enabled: false
  oidcServer:
    tls:
      enabled: false
EOF

Check the status of the Authorino CR again:

kubectl get authorino/authorino -o jsonpath='{.status.conditions}'
# [{"lastTransitionTime":"2022-05-26T16:11:50Z","reason":"Provisioned","status":"True","type":"Ready"}]

[eguzki]

if adding watcher to owned deployments, there is no need to requeue when the deployment is not ready.

[guicassolato]

If we do not return in line

authorino-operator/controllers/authorino_controller.go

Line 157 in 6d0039a

return ctrl.Result{Requeue: true}, nil

the reconciler will set the status of the CR to ready in line

authorino-operator/controllers/authorino_controller.go

Line 162 in 6d0039a

return ctrl.Result{}, updateStatusConditions(logger, authorinoInstance, r.Client, statusReady())

regardless of the status of the deployment, no?

[eguzki]

Then, instead of return ctrl.Result{Requeue: true}, nil , it should be:

return ctrl.Result{}, updateStatusConditions(logger, authorinoInstance, r.Client, statusNotReady())

Anyway, leave it as it is. It is working as expected

[guicassolato]

Added a new status condition DeploymentNotReady (message: 'Authorino Deployment resource not ready'), @eguzki

[eguzki]

I do not think you need to requeue when deployments are not ready because the controller is watching for deployments updates.

But leave it as it is, it does not do any harm