Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update secure protect connect fixing commands #1046

Merged
merged 4 commits into from
Dec 6, 2024
Merged

update secure protect connect fixing commands #1046

merged 4 commits into from
Dec 6, 2024

Conversation

R-Lawton
Copy link
Contributor

No description provided.

@R-Lawton R-Lawton marked this pull request as ready for review November 29, 2024 17:12
maleck13
maleck13 requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the developer section needs a re-think. Also a number of the resources are not marked as v1

@R-Lawton R-Lawton force-pushed the scpo branch 2 times, most recently from 7903f57 to a94fbe7 Compare December 2, 2024 22:25
jasonmadigan
jasonmadigan reviewed Dec 3, 2024
View reviewed changes
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
doc/user-guides/full-walkthrough/secure-protect-connect-openshift.md Outdated Show resolved Hide resolved
@R-Lawton R-Lawton force-pushed the scpo branch 2 times, most recently from 000e216 to 9646edb Compare December 3, 2024 23:54
@jasonmadigan jasonmadigan mentioned this pull request Dec 5, 2024
Closed
@jasonmadigan jasonmadigan mentioned this pull request Dec 5, 2024
Open
@jasonmadigan
Copy link
Member

@R-Lawton i'll do a run through of this today

@jasonmadigan
Copy link
Member

Lgtm

@jasonmadigan jasonmadigan reopened this Dec 6, 2024
@R-Lawton
update the docs to remove kuadrantctl
3800d28 
Signed-off-by: R-Lawton <[email protected]>
@R-Lawton
Updated SCP to currenrt versions and removed old and unecessary parts
cae66f0 
Signed-off-by: R-Lawton <[email protected]>

Updated SCP to currenrt versions and removed old and unecessary parts

Signed-off-by: R-Lawton <[email protected]>
@R-Lawton
add self signed cert and remove wildcard
d48172c 
Signed-off-by: R-Lawton <[email protected]>
@R-Lawton R-Lawton force-pushed the scpo branch 2 times, most recently from 5d38b8d to 32bc33c Compare December 6, 2024 14:21
@jasonmadigan jasonmadigan merged commit 18e3fb7 into Kuadrant:main Dec 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmadigan jasonmadigan jasonmadigan left review comments

@maleck13 maleck13 maleck13 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@R-Lawton @jasonmadigan @maleck13