Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.x #148

Closed
wants to merge 2 commits into from
Closed

v1.0.x #148

wants to merge 2 commits into from

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Nov 22, 2024

  • v1.0.0 updates

branch is a cul-dec-sac for 1.x, should not be merged (just created a PR for builds and previews)

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit 7c9bd31
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/6751deabce58d80008e32b46
😎 Deploy Preview https://deploy-preview-148--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan
Copy link
Member Author

/hold

@jasonmadigan jasonmadigan force-pushed the v1.0.x branch 3 times, most recently from b6d1b5e to f1eda71 Compare November 29, 2024 10:35
@jasonmadigan jasonmadigan marked this pull request as ready for review November 29, 2024 16:52
@jasonmadigan
Copy link
Member Author

/unhold

mkdocs.yml Show resolved Hide resolved
@jasonmadigan
Copy link
Member Author

@maleck13 I've gone through the docs. Tried to align to use kuadrant-v1.0.0 or release-1.0.0 branches where available and docs are up to date, but we've got a couple of exceptions which seem to have docs changes that have landed on main that are not on either of these branches (but do seem to be for 1.0.0).

TL;DR - have updated refs, they point to sensible things. One or two components are missing kuadrant-v1.0.0 branches, and need to be pinned to other refs. Let's ship this now.

A plan below:

Authorino

Has a kuadrant-v1.0.0 branch, but is several commits behind main and misses a bunch of docs changes that are on main that seem to be for 1.0.0:

Kuadrant/authorino@20d75a5

Recommend we pin to 20d75a5dbf592a580a7769a823ecdd67122d2ed3. Ideally new changes would create things in a new kuadrant-v1.0.0 branch (need some care to ensure some of the CEL docs changes on main get here too).

Kuadrant Operator

Has a release-v1.0.0 branch, seems to be up to date with late landing docs changes.

No change needed.

Authorino Operator

Has a kuadrant-v1.0.0 branch, and is up to date with main. The https://github.com/Kuadrant/authorino-operator/releases/tag/v0.16.0 tag points to the head of main also.

Recommend we pin to kuadrant-v1.0.0 - docs changes for 1.0.0 can go there.

Limitador

Does not have a kuadrant-v1.0.0 branch. Have not seen new docs changes land on main since the v1.6.0 change that look like they're for 1.0.0.

Recommend we keep pinned to the v1.6.0 tag.

Limitador Operator

Has a kuadrant-v1.0.0 branch, and is up to date with main.

Recommend we pin to kuadrant-v1.0.0 - docs changes for 1.0.0 can go there.

DNS Operator

Has a kuadrant-v1.0.0 branch. It is behind main, but with no docs changes.

Recommend we pin to kuadrant-v1.0.0 - docs changes for 1.0.0 can go there.

Arch, API Quickstart and kuadrantctl - keep pinned to main, these don't really change often other than arch.

@jasonmadigan
Copy link
Member Author

jasonmadigan commented Dec 2, 2024

Fixed Some broken links - need to fix:

WARNING -  Doc file 'authorino/docs/user-guides/authenticated-rate-limiting-envoy-dynamic-metadata.md' contains a link './features.md#common-feature-common-expression-language-cel', but the target 'authorino/docs/user-guides/features.md' is not found among documentation files.
WARNING -  Doc file 'authorino/docs/user-guides/deny-with-redirect-to-login.md' contains a link './features.md#common-feature-common-expression-language-cel', but the target 'authorino/docs/user-guides/features.md' is not found among documentation files.
WARNING -  Doc file 'authorino/docs/user-guides/external-metadata.md' contains a link './features.md#common-feature-common-expression-language-cel', but the target 'authorino/docs/user-guides/features.md' is not found among documentation files.
WARNING -  Doc file 'authorino/docs/user-guides/http-basic-authentication.md' contains a link './features.md#common-feature-common-expression-language-cel', but the target 'authorino/docs/user-guides/features.md' is not found among documentation files.
WARNING -  Doc file 'authorino/docs/user-guides/injecting-data.md' contains a link './features.md#common-feature-common-expression-language-cel', but the target 'authorino/docs/user-guides/features.md' is not found among documentation files.
WARNING -  Doc file 'authorino/docs/user-guides/json-pattern-matching-authorization.md' contains a link './features.md#common-feature-common-expression-language-cel', but the target 'authorino/docs/user-guides/features.md' is not found among documentation files.

Edit: needed to revert authorino to the release branch v0.20.0

@jasonmadigan
Copy link
Member Author

Waiting for Kuadrant/kuadrant-operator#1046

@jasonmadigan jasonmadigan force-pushed the v1.0.x branch 3 times, most recently from 9b70dca to 1805588 Compare December 5, 2024 15:25
@jasonmadigan
Copy link
Member Author

/hold

branch is a cul-dec-sac for 1.x, should not be merged (just created a PR for builds and previews)

Signed-off-by: Jason Madigan <[email protected]>
@jasonmadigan jasonmadigan force-pushed the v1.0.x branch 3 times, most recently from 458f203 to 0199654 Compare December 5, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants