Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DNSPolicy default geo logic #545

Closed
mikenairn opened this issue Apr 16, 2024 · 1 comment · Fixed by #549
Closed

Update DNSPolicy default geo logic #545

mikenairn opened this issue Apr 16, 2024 · 1 comment · Fixed by #549
Assignees

Comments

@mikenairn
Copy link
Member

mikenairn commented Apr 16, 2024

What

Update the default geo logic for loadbalanced policy types to make the creation of the default geo endpoint dependant on the current cluster existing in the desired default geo. If the there is no match the endpoint should not be added to the endpoint list .

Why

Currently it is assumed that we will always want the default geo to be set to something, if no cluster(s) matches the current default geo it will automatically select one that does exist. This is used primarily for route53 to ensure that a dnsName is accessible from all locations around the world. With distributed dns however, individual clusters cant be sure what the default geo should really be and should not try and be smart during the selection of it.

How

  • Update tests, ensure to add a test that doesn't default geo
  • Update DNSPolicy docs to call out the behaviour
  • Set DNSPolicy default geo to required

Related:

@mikenairn mikenairn moved this to In Progress in Kuadrant Apr 16, 2024
@mikenairn mikenairn moved this from In Progress to Todo in Kuadrant Apr 16, 2024
@mikenairn mikenairn removed the status in Kuadrant Apr 16, 2024
@mikenairn mikenairn moved this to Todo in Kuadrant Apr 16, 2024
@maksymvavilov maksymvavilov self-assigned this Apr 16, 2024
@maksymvavilov maksymvavilov moved this from Todo to In Progress in Kuadrant Apr 16, 2024
@maksymvavilov maksymvavilov linked a pull request Apr 16, 2024 that will close this issue
@maksymvavilov maksymvavilov moved this from In Progress to Ready For Review in Kuadrant Apr 17, 2024
@maksymvavilov maksymvavilov moved this from Ready For Review to In Progress in Kuadrant Apr 17, 2024
@maleck13
Copy link
Collaborator

@makslion as part of this pls ensure the DNSPolicy CRD has defaultGEO as required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants