Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed host check for CNAME targets during create and update changes #86

Closed
mikenairn opened this issue Apr 22, 2024 · 0 comments · Fixed by #93
Closed

Add managed host check for CNAME targets during create and update changes #86

mikenairn opened this issue Apr 22, 2024 · 0 comments · Fixed by #93
Assignees

Comments

@mikenairn
Copy link
Member

What

Update the plan logic to check that all CNAME target values exist, or will exist, if it is determined that the target should be part of the managed record set i.e. it has DNSRecord.rootHost as a suffix. If the target does not exist, an error should be added to the plan errors collection so the dnsrecord controller can see it and add it as an error in the DNSRecord status.

Why

It is expected that any records using a rootHost are entirely managed by the dns operator and therefore should always have a valid chain of records. The endpoints in the local record might not contain all the steps in that chain, but the zone in which they are being published should, or should eventually, and until they do each record should report an error.

This is required for the likes of default geos where not all DNSRecords will be creating a default geo endpoint, but others might be referring to it in an endpoints target.

@mikenairn mikenairn self-assigned this Apr 22, 2024
@maleck13 maleck13 moved this to Todo in Kuadrant Apr 22, 2024
@mikenairn mikenairn moved this from Todo to In Progress in Kuadrant Apr 22, 2024
@mikenairn mikenairn moved this from In Progress to Ready For Review in Kuadrant Apr 24, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant