Root host target checks #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add step in the plan to verify the targets of all CNAME records being created or updated. If the target is calculated to be a subdomain of the plans root host, it must exist in the zone or will exist after the changes are applied. Makes use of the plans DomainFilters since this is already used to filter down to relevant records and allows us to use the same logic to check for matches in dnsName values or targets. Plan was updated to ensure that a DomainFilter is always set for the RootHost if one is specified.
mikenairn
force-pushed
the
root_domain_target_checks
branch
from
e3fafe3 to
03b2160
Compare
philbrookes
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #86
Add step in the plan to verify the targets of all CNAME records being created or updated. If the target is calculated to be a subdomain of the plans root host, it must exist in the zone or will exist after the changes are applied.
Makes use of the plans DomainFilters since this is already used to filter down to relevant records and allows us to use the same logic to check for matches in dnsName values or targets. Plan was updated to ensure that a DomainFilter is always set for the RootHost if one is specified.