aws health checks #78
Conversation
|
|
||
| address, _ := provider.GetEndpointAddress(endpoint) | ||
|
|
||
| if exists { |
There was a problem hiding this comment.
when we update / create the health check we should add this call to a metric so we can track the number of calls to the provider. I believe @makslion is adding a metric like that
There was a problem hiding this comment.
I guess the client might be the place to do that?
philbrookes
force-pushed
the
gh-44
branch
2 times, most recently
from
e06adf4 to
9b702a8
Compare
philbrookes
force-pushed
the
gh-44
branch
2 times, most recently
from
ed0f1d1 to
d749d02
Compare
philbrookes
force-pushed
the
gh-44
branch
7 times, most recently
from
2112bb9 to
adc6274
Compare
philbrookes
force-pushed
the
gh-44
branch
2 times, most recently
from
3bdbb30 to
314fb25
Compare
There was a problem hiding this comment.
There being not tests here is really not ideal. We need to make sure we get these in place @philbrookes can you link to an issue
@mikenairn In order to unblock moving kuadarant operator back to main of dns operator, I think we can make an exception for this knowing the focus will be on adding tests before we do the next release of DNS operator?
My intention was to keep this issue open until the tests are added and the logic is firmed up more. #44 |
When we are deleting a DNSRecord we just ignore all errors relating to the ManagedZone being missing since there is nothing we can do about it, and we don't want the record staying around forever. Check was missing for health checks Kuadrant#78
When we are deleting a DNSRecord we just ignore all errors relating to the ManagedZone being missing since there is nothing we can do about it, and we don't want the record staying around forever. Check was missing for health checks Kuadrant#78
First pass at AWS health checks in DNS Operator.
Some uses-cases not fully covered, and no smart backoff, or e2e tests yet.
Related PR for kuadrant-operator:
Kuadrant/kuadrant-operator#543