Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Provider Health Checks #44

Closed
mikenairn opened this issue Mar 6, 2024 · 0 comments
Closed

Add AWS Provider Health Checks #44

mikenairn opened this issue Mar 6, 2024 · 0 comments

Comments

@mikenairn
Copy link
Member

mikenairn commented Mar 6, 2024

What

Add implementation of health checks for AWS provider.

How

We had AWS provider health checks in MGC but we removed them when we thought we weren't going forward with provider health checks Kuadrant/multicluster-gateway-controller@89e1893. This can be used for reference.

Areas to consider in this work:

  • New health check is required if an IP / CNAME in spec doesn't have a matching status health check
  • When a new health check is required
    • List health checks in Provider
    • Add all relevant health checks to DNS Record status
    • Create any absent health checks
    • Delete any obsolete health checks

## Overview

  • Health check defined in DNS Policy.
  • Health check config is propagated to the DNS Operator via the DNS Record spec (in same format as DNS Policy).
  • When values are present in DNS Record and health checks are supported in the provider: health checks are created in provider for all A record targets or external CNAME targets.
  • Health checks created with name including the owner ID (if present)
  • Store health check IDs in status of the DNS Record
    • Hostname
    • IP / External CNAME
    • Health check ID
  • Remove health checks for IPs / external CNAMEs in the status that are no longer in the endpoints.
    • If the health check delete fails because it's already gone, then remove it from the status.
@philbrookes philbrookes moved this to Todo in Kuadrant Mar 14, 2024
@philbrookes philbrookes moved this from Todo to In Progress in Kuadrant Mar 20, 2024
@philbrookes philbrookes self-assigned this Mar 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 4, 2024
…ecord-spec

add health check block to DNSRecord spec
@maleck13 maleck13 moved this from In Progress to Ready For Review in Kuadrant Apr 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 17, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Apr 24, 2024
@philbrookes philbrookes moved this from Done to In Progress in Kuadrant Apr 24, 2024
@philbrookes philbrookes moved this from In Progress to Done in Kuadrant Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants