Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DiceTool): Resolve #1327, #1328 #1350

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat(DiceTool): Resolve #1327, #1328 #1350

merged 1 commit into from
Jan 15, 2024

Conversation

SuikaXhq
Copy link
Contributor

@SuikaXhq SuikaXhq commented Jan 15, 2024

Resolves #1327
Resolves #1328

Note that in client/src/game/dice/state.ts, I just use the first element of result list because I don't quite understand why the list always contains only one result item. Using the first item just works well.

@Kruptein
Copy link
Owner

Note that in client/src/game/dice/state.ts, I just use the first element of result list because I don't quite understand why the list always contains only one result item. Using the first item just works well.

The underlying dice API offers capabilities to do multiple rolls at the same time that should not be added together (e.g. 2d6+3 1d4-2, would do the 2 rolls at the same time and keep track of their underlying totals and subtotals as 2 separate entries).

The frontend UI of PA does not offer this option however so it's fine to take the first element only.

@Kruptein
Copy link
Owner

did you btw end up receiving my response to your mail?

@Kruptein Kruptein merged commit 85d581c into Kruptein:dev Jan 15, 2024
5 checks passed
@SuikaXhq
Copy link
Contributor Author

are you referring to the email I sent to you on Oct. 17? It seems failed to receive your response as I haven't found any email related to that since then.

@SuikaXhq SuikaXhq deleted the #1328 branch January 16, 2024 09:17
@Kruptein
Copy link
Owner

Oh, I'll try again then :V because I did reply to that mail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Show who rolled what in the log [FEAT] Explain the dice rolls in the log
2 participants