Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Show who rolled what in the log #1328

Closed
Oreolek opened this issue Nov 29, 2023 · 5 comments · Fixed by #1350
Closed

[FEAT] Show who rolled what in the log #1328

Oreolek opened this issue Nov 29, 2023 · 5 comments · Fixed by #1350

Comments

@Oreolek
Copy link

Oreolek commented Nov 29, 2023

The dice log is too terse and doesn't show who rolled what without hovering over each roll. I constantly need this info

Example: [user]: 1d6

@SuikaXhq
Copy link
Contributor

SuikaXhq commented Jan 15, 2024

I happen to have the same need and I have patched it in my own fork
you can refer to: (SuikaXhq@59df6f4)
the patch also include your other issue #1327

@Oreolek
Copy link
Author

Oreolek commented Jan 15, 2024

i'm using the docker image so can't just use code patches or mods

@SuikaXhq
Copy link
Contributor

sadly I haven't used the docker image so I can't help.
I also think showing roll user and details is really useful when there are concurrent rolls. Hopefully a more decent update could make it.

@Kruptein
Copy link
Owner

I do have some things planned for the dice roller, but they are not progressing fast.

That said, @SuikaXhq why don't you submit a PR with your changes? It would be a nice help for some people.

@SuikaXhq
Copy link
Contributor

well, in the beginning I was just patching for my own use so the code may look casual.
I will submit a PR later.

SuikaXhq added a commit to SuikaXhq/PlanarAlly that referenced this issue Jan 15, 2024
SuikaXhq added a commit to SuikaXhq/PlanarAlly that referenced this issue Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants