Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kwarg change #52

Merged
merged 1 commit into from
Jan 3, 2022
Merged

kwarg change #52

merged 1 commit into from
Jan 3, 2022

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Aug 16, 2021

#39 was closed without a fix, it's outdated and confusing:

Crayons.jl/src/test_prints.jl

Line 23 in 4cf50b8

test_256_colors(codes::Bool = true) = test_256_colors(stdout, codes)

@KristofferC
Copy link
Owner

Let's just make it a real keyword argument instead?

@t-bltg
Copy link
Contributor Author

t-bltg commented Aug 17, 2021

Let's just make it a real keyword argument instead?

👍 I've changed it.

@KristofferC KristofferC merged commit 5121038 into KristofferC:master Jan 3, 2022
@t-bltg t-bltg deleted the patch-1 branch January 3, 2022 10:55
@KristofferC KristofferC mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bltg @KristofferC