Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated readme for test_xxx_colors functions #39

Closed
Micket opened this issue Aug 8, 2020 · 4 comments
Closed

Outdated readme for test_xxx_colors functions #39

Micket opened this issue Aug 8, 2020 · 4 comments

Comments

@Micket
Copy link

Micket commented Aug 8, 2020

Crayons.test_256_colors(shownumbers::Bool=true)
Crayons.test_24bit_colors(shownumbers::Bool=false)

should probably be codes, but, also, shouldn't include ::Bool unless I'm missing something, and also also, it isn't a named argument anyway so it can't even be named regardless.

@Micket Micket changed the title Outdated readme Outdated readme for test_xxx_colors functions Aug 8, 2020
@KristofferC
Copy link
Owner

Hm,

bild

bild

The shownumbers is not a keyword argument, just a description of the positional argument.

@Micket
Copy link
Author

Micket commented Aug 11, 2020

I see, well, the statement

if your terminal supports 256 colors, use Crayons.test_256_colors(shownumbers::Bool=true)

fooled a newbie like me a bit as it kind of looks like a keyword argument.

@KristofferC
Copy link
Owner

Yeah, I think this exact thing happened before. I guess I would put a semicolon to indicate the start of the keywords. But I could change it to some other syntax if you have a good suggestion. Or perhaps making it an actual keyword argument makes sense.

@KristofferC
Copy link
Owner

I'll close this for now since I haven't figured out a better way to write it heh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants