-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RomApp] Adding a database with SQLite #12313
Conversation
we need to update the RomParameter.json without expensive computations if stuff is in the data_base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments.
Also, if possible, make a little doc (couple of lines) for the functions that are missing one (specially in the RomDatabase
class)
Looks good to me, I checked mostly the parts that have to do with the ANN |
Can I get an approval? |
📝 Description
This PR adds a database for the rom simulations using the sqlite3 python library.
The RomDatabase is a property of the RomManager. The main change in the behaviour is that now all snapshots are added to the database and when the error is to be computed, the SVD of the solutions is to be calculated, the SVD residuals projected is to the calculated, etc, the database retrieves the required npy files from the respective npy_files folder and once the npy file is loaded into fast memory, the calculation proceeds with the previously existing logic.
The files generated by the database are
🆕 Changelog