[RomApp] Separate Basis Generation and File Writing Processes #12271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbravo555
added
FastPR
Rbravo555
added a commit
that referenced
this pull request
Apr 12, 2024
we need to update the RomParameter.json without expensive computations if stuff is in the data_base
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR aims to split file generation/updating from the computation of the computationally expensive SVD, ensuring efficiency and scalability.
As part of our ongoing efforts to optimize our architecture, we plan to introduce a database that manages RightBasis and LeftBasis in future Prs. When the database is in place, only the file updating will be launched if the bases already exist.
🆕 Changelog