[GeoMechanicsApplication] Remove swapping faces in condition process #12227

rfaasse · 2024-03-26T13:17:16Z

📝 Description
We have identified that certain 3D conditions in GeoMechanicsApp are not functioning correctly due to the presence of edge and face swapping. These lines were originally introduced as a workaround for a bug that has since been fixed. See issues #9818 #9422.

However, it has come to our attention that these workarounds are now causing issues with our 3D boundary conditions, therefore they are removed, test cases adjusted and new test cases added.

…st cases

…ed 2 test cases to thermal

…apping-faces

…ng yet.

This reverts commit d5c51ad.

This reverts commit 2b766af.

This reverts commit 7adf82f.

WPK4FEM

And thank you for also updating the existing README with the added thermal tests.
Remaining comment is only on consistency in formatting of mentioned units.

WPK4FEM · 2024-03-28T10:15:40Z

applications/GeoMechanicsApplication/tests/hexa_8n_normal_load/README.md

+    -   The X, Y and Z displacements in the bottom four nodes (1, 2, 3 and 4) are fixed.
+-   Material:
+    -   The material is described using a linear elastic material with a `LinearElastic3DLaw`, a Young's modulus
+        of 3.0e7 kPa and a Poisson ratio of 0.0.


Mostly we have put units between [ ].
See also line 19, 23 and 24

avdg81

@mnabideltares and @rfaasse: thank you for taking out the work-around that was previously required. This helps to make the code more readable. And I'm pleased to see that you've added a few more tests. Great!

...ns/GeoMechanicsApplication/custom_conditions/surface_normal_load_3D_diff_order_condition.cpp

applications/GeoMechanicsApplication/tests/hexa_8n_normal_load/MaterialParameters.json

avdg81 · 2024-03-28T12:14:34Z

applications/GeoMechanicsApplication/tests/hexa_8n_normal_load/ProjectParameters.json

+        "kratos_module": "KratosMultiphysics.GeoMechanicsApplication",
+        "process_name":  "ApplyScalarConstraintTableProcess",
+        "Parameters":    {
+            "model_part_name": "PorousDomain.BottomFixed",


Question: is it intentional that only the bottom nodes have prescribed water pressures? Or should the fixed value be applied to all nodes?

I think this should be enough (correct me if I'm wrong @WPK4FEM), since now we have a reference pressure (and also since ignore undrained is set to true)

Changed to force the entire element to 0.0 water pressure

applications/GeoMechanicsApplication/tests/test_normal_load_on_hexa_element.py

rfaasse

I processed/replied to all that I could.

...ns/GeoMechanicsApplication/custom_conditions/surface_normal_load_3D_diff_order_condition.cpp

rfaasse · 2024-03-28T12:45:02Z

applications/GeoMechanicsApplication/tests/hexa_8n_normal_load/README.md

+    -   The X, Y and Z displacements in the bottom four nodes (1, 2, 3 and 4) are fixed.
+-   Material:
+    -   The material is described using a linear elastic material with a `LinearElastic3DLaw`, a Young's modulus
+        of 3.0e7 kPa and a Poisson ratio of 0.0.


rfaasse · 2024-03-28T12:56:51Z

applications/GeoMechanicsApplication/tests/hexa_8n_normal_load/ProjectParameters.json

+        "kratos_module": "KratosMultiphysics.GeoMechanicsApplication",
+        "process_name":  "ApplyScalarConstraintTableProcess",
+        "Parameters":    {
+            "model_part_name": "PorousDomain.BottomFixed",


I think this should be enough (correct me if I'm wrong @WPK4FEM), since now we have a reference pressure (and also since ignore undrained is set to true)

applications/GeoMechanicsApplication/tests/test_normal_load_on_hexa_element.py

applications/GeoMechanicsApplication/tests/hexa_8n_normal_load/MaterialParameters.json

WPK4FEM

Thank you, I think this is good to go.

…vant

avdg81

Many thanks for the final changes. I believe we're good to go :-)

mnabideltares and others added 3 commits February 12, 2024 13:20

Remoded face swapping for Triangle3D3, and 3D6, Fixed the existing te…

ec73f5e

…st cases

Removed face swapping for Quadrilateral3D4, and Quadrilateral3D8, Add…

761d14a

…ed 2 test cases to thermal

Merge remote-tracking branch 'origin/master' into geo/12026-remove-sw…

1d8d851

…apping-faces

rfaasse self-assigned this Mar 26, 2024

rfaasse added the GeoMechanics Issues related to the GeoMechanicsApplication label Mar 26, 2024

rfaasse and others added 17 commits March 27, 2024 09:40

Fix sign of the normal stresses for 3D cases

3a6681c

Refactored diff order condition calculation function

545ef42

Minor refactoring

646836e

Renamed test to reflect diff order character

d5c51ad

Renamed test to mention diff order

2b766af

Renamed triangle test to mention diff order

7adf82f

Some code and comment improvements

0fdb128

Added test for hexa_8n_normal_load test, which does not assert anythi…

de213c3

…ng yet.

Revert "Renamed test to reflect diff order character"

d1e38a1

This reverts commit d5c51ad.

Revert "Renamed test to mention diff order"

04ced09

This reverts commit 2b766af.

Revert "Renamed triangle test to mention diff order"

dbd786b

This reverts commit 7adf82f.

Added asserts in the normal load test for hexa element

b9f44c8

Renames

abc89b4

Added clarifying comments for the new test

a0efacc

Fixed absorbing boundary 3d tests

7685203

Added README + schematic for the structure

a1445a8

Minor fixes for the README.md

e1147dd

rfaasse linked an issue Mar 28, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Remove swapping edges and faces from "FindNeighbourElementsOfConditionsProcess" #12026

Closed

rfaasse requested review from WPK4FEM and avdg81 March 28, 2024 10:00

rfaasse marked this pull request as ready for review March 28, 2024 10:00

Added new test case specifications to overall README.md

4bde10c

WPK4FEM reviewed Mar 28, 2024

View reviewed changes

rfaasse assigned mnabideltares Mar 28, 2024

avdg81 reviewed Mar 28, 2024

View reviewed changes

Processing review comments

ee4d1d9

rfaasse commented Mar 28, 2024

View reviewed changes

WPK4FEM previously approved these changes Mar 28, 2024

View reviewed changes

Fixing the entire element to a zero water pressure, since it's irrele…

989971e

…vant

rfaasse dismissed WPK4FEM’s stale review via 989971e March 28, 2024 15:08

Added new test to the test_GeoMechanicsApplication.py script

5d0fb9f

avdg81 approved these changes Mar 28, 2024

View reviewed changes

rfaasse enabled auto-merge (squash) March 28, 2024 16:04

rfaasse merged commit ca1560e into master Mar 28, 2024
10 of 11 checks passed

rfaasse deleted the geo/12026-remove-swapping-faces branch March 28, 2024 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Remove swapping faces in condition process #12227

[GeoMechanicsApplication] Remove swapping faces in condition process #12227

rfaasse commented Mar 26, 2024 •

edited

Loading

WPK4FEM left a comment

WPK4FEM Mar 28, 2024

rfaasse Mar 28, 2024

avdg81 left a comment

avdg81 Mar 28, 2024

rfaasse Mar 28, 2024

rfaasse Mar 28, 2024

rfaasse left a comment

rfaasse Mar 28, 2024

rfaasse Mar 28, 2024

WPK4FEM left a comment

avdg81 left a comment

[GeoMechanicsApplication] Remove swapping faces in condition process #12227

[GeoMechanicsApplication] Remove swapping faces in condition process #12227

Conversation

rfaasse commented Mar 26, 2024 • edited Loading

WPK4FEM left a comment

Choose a reason for hiding this comment

WPK4FEM Mar 28, 2024

Choose a reason for hiding this comment

rfaasse Mar 28, 2024

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

avdg81 Mar 28, 2024

Choose a reason for hiding this comment

rfaasse Mar 28, 2024

Choose a reason for hiding this comment

rfaasse Mar 28, 2024

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

rfaasse Mar 28, 2024

Choose a reason for hiding this comment

rfaasse Mar 28, 2024

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

rfaasse commented Mar 26, 2024 •

edited

Loading