-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement box-shadow with Azure Blur #859
Conversation
So... Based on @SimonSapin's suggestion in #13, and his work on providing Python bindings for AzureBlur, I implemented the box shadow drawing using This is the new shadow, using the same code as above: I still have to work on the Edit: I cannot seem to get |
I'm closing this PR for now (see #13). |
This PR is an attempt to solve #13.
I merged and updated what @liZe did back in 2013 in #149.
I also wrote the property rule to support
box-shadow
.While I understand the points raised in #13 and #149, I strongly believe that it's better to have this implementation, improvable as it may be, rather than nothing.
Furthermore, @liZe did some awesome work, even though it's been deemed not so efficient.
Now that it's been integrated, we can consider improving the implementation, but at least, we can generate basic shadows.
Here's an example of how shadows are rendered:
Not that bad looking IMO, and can be improved with a little CSS tweaking.