box-shadow and text-shadow support #149
Conversation
|
Awesome work ! |
|
Can this still be merged? |
|
It works quite well and probably can be merged. The main problem is that the changes rely on PIL/pillow. @SimonSapin what do you think about that? |
|
Requiring PIL makes me very sad, but I don’t have an alternative to propose right now. |
|
Of course, another big problem of this implementation is that it relies on bitmaps for the shadows, even in PDFs. But as Simon, this bad solution is the best solution I can think of. The real solution is to have this in cairo, but that will probably never happen. IMO, we can merge this PR because the added code is small, simple, and doesn't change anything in the architecture. We must open another bug to remember that pixmaps in PDFs are bad and that this implementation is slooooow as hell. Oh, and I'd really like someone to remove this awful 4/3 ratio before merging. |
| thickness, enable_hinting) | ||
|
|
||
| for x, y, blur, color in reversed(textbox.style.text_shadow): | ||
| # TODO: fix this 4/3 ratio |
There was a problem hiding this comment.
Please, fix me before merging!
|
I close this PR as it won't be merged. Depending on the PIL and using raster blurs are an awful solution. |
This commit highlights placeholders in letter previews the same way that we do for emails and text messages. The implementation is slightly different because WeasyPrint doesn’t support box-shadow (see Kozea/WeasyPrint#149 (comment) for reasons). Luckily WeasyPrint _does_ support CSS3 multiple backgrounds, so we can mask the curved edges with SVG background images instead. This wouldn’t be a great solution on the web because it you might get a flash of unstyled placeholder as the images loaded. But because the PDF is rendered completely before it’s served it shouldn’t be a problem.
This commit highlights placeholders in letter previews the same way that we do for emails and text messages. The implementation is slightly different because WeasyPrint doesn’t support box-shadow (see Kozea/WeasyPrint#149 (comment) for reasons). Luckily WeasyPrint _does_ support CSS3 multiple backgrounds, so we can mask the curved edges with SVG background images instead. This wouldn’t be a great solution on the web because it you might get a flash of unstyled placeholder as the images loaded. But because the PDF is rendered completely before it’s served it shouldn’t be a problem.
This commit highlights placeholders in letter previews the same way that we do for emails and text messages. The implementation is slightly different because WeasyPrint doesn’t support box-shadow (see Kozea/WeasyPrint#149 (comment) for reasons). Luckily WeasyPrint _does_ support CSS3 multiple backgrounds, so we can mask the curved edges with SVG background images instead. This wouldn’t be a great solution on the web because it you might get a flash of unstyled placeholder as the images loaded. But because the PDF is rendered completely before it’s served it shouldn’t be a problem.
This commit highlights placeholders in letter previews the same way that we do for emails and text messages. The implementation is slightly different because WeasyPrint doesn’t support box-shadow (see Kozea/WeasyPrint#149 (comment) for reasons). Luckily WeasyPrint _does_ support CSS3 multiple backgrounds, so we can mask the curved edges with SVG background images instead. This wouldn’t be a great solution on the web because it you might get a flash of unstyled placeholder as the images loaded. But because the PDF is rendered completely before it’s served it shouldn’t be a problem.
|
Hi, is there any plan to support |
This pull request generates a raster image included in the generated PDF, that's an ugly solution. Unless there's a clean way to include blurs in PDF files, and unless this feature is included in Cairo, I don't see how we could include blurs in a clean way. |
|
Worth noting that box shadow can be used without blurs. So I guess it would be possible to support a subset of box-shadow where blur isn't used. |
That’s right, and that would be useful in some cases. We can continue to discuss on #13 and see if some people are interested in providing and/or using this feature. |
Fix #13.