-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement addAll functions for JsonArrayBuilder #2156
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
de88eda
addAll functions for JsonArrayBuilder
aSemy cf8be83
revert formatting changes
aSemy fc55c4b
convert addAll to expression body
aSemy 8c2e411
verify addAll modifies the array & returns true
aSemy ef6a5dd
test for adding null
aSemy 4f345b6
add 'not modified' tests
aSemy ae6d93b
more 'not modified' tests
aSemy b046eaf
update api file
aSemy f38d11d
add `@ExperimentalSerializationApi` to new funcions, tidy `addAll(var…
aSemy 0f7b113
update API dump
aSemy ec87d84
remove JsonArrayBuilder addAll varargs util
aSemy dc46b70
remove JsonArrayBuilder addAll varargs JsonElement util
aSemy d7385a2
add `@return` KDoc for JsonArrayBuilder.addAll
aSemy 99eb6c8
update API dump
sandwwraith e1440d6
return star import
sandwwraith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good this function's signature matches one from
MutableList
— we can add superclass later without breaking anything 👍🏻