Implement addAll functions for JsonArrayBuilder #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aSemy
commented
Jan 14, 2023
formats/json/commonMain/src/kotlinx/serialization/json/JsonElementBuilders.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Feb 1, 2023
formats/json/commonMain/src/kotlinx/serialization/json/JsonElementBuilders.kt
Outdated
Show resolved
Hide resolved
|
sandwwraith
requested changes
Apr 21, 2023
There was a problem hiding this comment.
Hi, thanks for your PR and sorry it took so long to process it. I think we can accept this functionality after some refining. As you correctly said, all new functions should be marked with @ExperimentalSerializationApi. Can you also please rebase your branch on the latest dev?
| * | ||
| * @return `true` if the list was changed as the result of the operation. | ||
| */ | ||
| public fun addAll(elements: Collection<JsonElement>): Boolean = |
There was a problem hiding this comment.
It's good this function's signature matches one from MutableList — we can add superclass later without breaking anything 👍🏻
formats/json/commonMain/src/kotlinx/serialization/json/JsonElementBuilders.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/JsonElementBuilders.kt
Outdated
Show resolved
Hide resolved
aSemy
force-pushed
the
feat/json_array_add_all
branch
from
75cba74
to
8b73cfc
Compare
aSemy
force-pushed
the
feat/json_array_add_all
branch
from
1c894a0
to
f6f64f2
Compare
sandwwraith
reviewed
May 2, 2023
| * @return `true` if the list was changed as the result of the operation. | ||
| */ | ||
| @ExperimentalSerializationApi | ||
| public fun JsonArrayBuilder.addAll(vararg elements: JsonElement): Boolean { |
There was a problem hiding this comment.
Oops, I missed that one. It's now removed.
There was a problem hiding this comment.
hey @sandwwraith, sorry I forgot this! Would you mind updating it? You should have permissions.
…arg elements: JsonElement)`
aSemy
force-pushed
the
feat/json_array_add_all
branch
from
50b3420
to
dc46b70
Compare
sandwwraith
requested changes
May 9, 2023
| * @return `true` if the list was changed as the result of the operation. | ||
| */ | ||
| @ExperimentalSerializationApi | ||
| public fun JsonArrayBuilder.addAll(vararg elements: JsonElement): Boolean { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2127
addAll()method onJsonArrayBuildervarargShould the new functions be marked with
@ExperimentalSerializationApi?