@JsonClassDiscriminator and @InheritableSerialInfo #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdvrieze
reviewed
Jul 21, 2021
core/commonMain/src/kotlinx/serialization/PolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
shanshin
approved these changes
Jul 28, 2021
core/commonTest/src/kotlinx/serialization/SerializersLookupEnumTest.kt
Outdated
Show resolved
Hide resolved
qwwdfsad
reviewed
Jul 29, 2021
core/commonMain/src/kotlinx/serialization/PolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
core/commonMain/src/kotlinx/serialization/PolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
sandwwraith
force-pushed
the
inheritable-serial-info
branch
from
402be0c
to
c478b94
Compare
qwwdfsad
requested changes
Aug 23, 2021
formats/json/commonMain/src/kotlinx/serialization/json/internal/Polymorphic.kt
Outdated
Show resolved
Hide resolved
…gure discriminator per polymorphic base class Fixes #546
sandwwraith
force-pushed
the
inheritable-serial-info
branch
from
f2ac92f
to
ae9fb69
Compare
qwwdfsad
approved these changes
Aug 26, 2021
| public abstract fun discriminator ()Ljava/lang/String; | ||
| } | ||
|
|
||
| public final class kotlinx/serialization/json/JsonClassDiscriminator$Impl : kotlinx/serialization/json/JsonClassDiscriminator { |
There was a problem hiding this comment.
[out of scope] Do we want to change the generation of synthetic implementation in the face of 1.6.0 annotation instantiation?
There was a problem hiding this comment.
Yes, when Native & JS implementations would be fully ready
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.