@JsonClassDiscriminator and other serial info annotations in sealed, polymorphic and object serializables #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…morphic base class Fixes #546
shanshin
reviewed
May 27, 2021
core/commonTest/src/kotlinx/serialization/SerialDescriptorAnnotationsTest.kt
Outdated
Show resolved
Hide resolved
| objectInstance: T, | ||
| classAnnotations: Array<Annotation> | ||
| ) : this(serialName, objectInstance) { | ||
| (this.descriptor as SerialDescriptorImpl).annotations = classAnnotations.asList() |
There was a problem hiding this comment.
I have the impression that this is not the best idea to do SerialDescriptorImpl almost mutable because of one issue.
Also, explicit conversion to SerialDescriptorImpl looks dangerous.
Maybe solve the problem where it appears - in serializer? Create private var property and rewrite it in the secondary constructor or other alternatives.
There was a problem hiding this comment.
The problem is, the secondary constructor is called after all init blocks and properties initializers. I considered the following alternatives:
- Mutable (to some reasonable extent) serialDescriptorImpl — current solution. I can add
buildSerialDescriptorInternalfunction to avoid downcast to be sure this won't break. - Store the builder in property, call
.buildon every access topublic val descriptor— I don't like copying every time - Store descriptor in private mutable property, rebuild it from scratch (because we do not have a copying mechanism) every time. Seems reasonable, although a bit boilerplaite-ish. However, I do not see any strong objections to this solution, so I can rewrite everything to it
formats/json/commonTest/src/kotlinx/serialization/features/JsonClassDiscriminatorTest.kt
Show resolved
Hide resolved
shanshin
reviewed
May 27, 2021
formats/json/commonMain/src/kotlinx/serialization/json/internal/Polymorphic.kt
Show resolved
Hide resolved
|
Superseded by #1608 as we changed the design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, requires a special branch of the Kotlin compiler to work (will likely be merged in 1.5.20)