tests(rate-limiting): refactor tests #9764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
kikito
reviewed
Nov 16, 2022
.ci/run_tests.sh
Outdated
| @@ -33,14 +33,14 @@ fi | |||
| if [ "$TEST_SUITE" == "integration" ]; then | |||
| if [[ "$TEST_SPLIT" == first* ]]; then | |||
| # GitHub Actions, run first batch of integration tests | |||
| eval "$TEST_CMD" $(ls -d spec/02-integration/* | sort | grep -v 05-proxy) | |||
| : | |||
There was a problem hiding this comment.
These changes seem to be geared towards running only RL specs, for easy development. If that is the case then this file needs to be restored to the original before this PR can be merged. Just leaving this as a reminder
.github/workflows/build_and_test.yml
Outdated
| @@ -75,6 +75,7 @@ jobs: | |||
| name: Lint, Doc and Unit tests | |||
| runs-on: ubuntu-22.04 | |||
| needs: build | |||
| if: false | |||
There was a problem hiding this comment.
Ditto: development aids, changes must be undone before merging
ADD-SP
force-pushed
the
add_sp/tests-rewrite-tests-of-rl-plugin
branch
3 times, most recently
from
f8a9d33 to
1ea8994
Compare
ADD-SP
force-pushed
the
add_sp/tests-rewrite-tests-of-rl-plugin
branch
7 times, most recently
from
86b5fc7 to
570d0da
Compare
ADD-SP
force-pushed
the
add_sp/tests-rewrite-tests-of-rl-plugin
branch
from
570d0da to
1735b91
Compare
github-actions
bot
removed
the
chore
3 tasks
ADD-SP
force-pushed
the
add_sp/tests-rewrite-tests-of-rl-plugin
branch
5 times, most recently
from
4eb7c01 to
38f6be8
Compare
ADD-SP
force-pushed
the
add_sp/tests-rewrite-tests-of-rl-plugin
branch
3 times, most recently
from
83bf220 to
c45a9d5
Compare
ADD-SP
force-pushed
the
add_sp/tests-rewrite-tests-of-rl-plugin
branch
from
c45a9d5 to
b39f266
Compare
dndx
approved these changes
Dec 1, 2022
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
… JSON nulls (#9764) * fix(pdk): fix a bug that pdk.log.serialize() will throw an error when json entity set via pdk.log.set_serialize_value contains cjson.null as value. * handle cdata null Cherry-picked from #13376 --------- Co-authored-by: Zachary Hu <[email protected]> (cherry picked from commit 163f72a) Co-authored-by: Robin Xiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BLOCKS #9538
The tests of the rate-limiting plugin have many flaky factors, and it is hard to debug. Moreover, the structure of these test cases needs some improve, so I refactor it.
FT-3543