perf(rate-limiting): sync to redis periodically #9538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD-SP
force-pushed
the
add_sp/perf-rate-limiting
branch
from
da44d69 to
bb5dfa9
Compare
ADD-SP
force-pushed
the
add_sp/perf-rate-limiting
branch
4 times, most recently
from
097e933 to
cdcfe60
Compare
ADD-SP
force-pushed
the
add_sp/perf-rate-limiting
branch
from
cdcfe60 to
de20bd5
Compare
chronolaw
changed the title
chronolaw
reviewed
Oct 14, 2022
ADD-SP
force-pushed
the
add_sp/perf-rate-limiting
branch
6 times, most recently
from
93a0080 to
30c714e
Compare
chronolaw
reviewed
Oct 18, 2022
chronolaw
reviewed
Oct 18, 2022
chronolaw
reviewed
Oct 18, 2022
fffonion
reviewed
Oct 19, 2022
fffonion
reviewed
Oct 19, 2022
fffonion
reviewed
Oct 19, 2022
ADD-SP
force-pushed
the
add_sp/perf-rate-limiting
branch
5 times, most recently
from
8836b84 to
a2ab543
Compare
ADD-SP
force-pushed
the
add_sp/perf-rate-limiting
branch
3 times, most recently
from
7195057 to
438061f
Compare
StarlightIbuki
force-pushed
the
add_sp/perf-rate-limiting
branch
from
438061f to
2098f43
Compare
chronolaw
reviewed
Jun 12, 2023
StarlightIbuki
force-pushed
the
add_sp/perf-rate-limiting
branch
2 times, most recently
from
db9aee5 to
52bfe24
Compare
chronolaw
reviewed
Jun 12, 2023
* perf(tools/timestamp): using Lua std API instead of `luatz` module for function `get_timestamps` Thanks to Dan Carley for fixing the ACL test. dcarley@f18458d fix merge issues refactor Apply suggestions from code review revert unnecessary changes Co-authored-by: Chrono <[email protected]>
StarlightIbuki
force-pushed
the
add_sp/perf-rate-limiting
branch
from
52bfe24 to
a5c1729
Compare
StarlightIbuki
force-pushed
the
add_sp/perf-rate-limiting
branch
from
a5c1729 to
63e7f13
Compare
chronolaw
approved these changes
Jun 13, 2023
fffonion
reviewed
Jun 13, 2023
hbagdi
reviewed
Jun 13, 2023
windmgc
pushed a commit
that referenced
this pull request
Jun 26, 2023
#9538 was created before 3.3.0 released, so the remove_fields was added for 3.3.0. Now we are developing 3.4, so we need to move that to the correct place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BLOCKED BY #9764✅Adds a new configuration
sync_rateto theredispolicy, which synchronizes metrics to redis periodically instead of on every request.Checklist
Issue reference
Fix FT-3464
Fix #8729