fix(upstreams) mark the update timer as scheduled #8858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the balancer state timer is running, it updates the flag that avoids it to be started again. this commit adds this same behavior to scheduling the update timer, instead of waiting for the first run
flrgh
approved these changes
May 25, 2022
aboudreault
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the balancer state timer is running, it updates the flag that avoids it to be started again on every run. This PR adds the same behavior to scheduling the update timer, instead of waiting for the first run. This change avoids that an upstream that is updated more than once before the eventual consistency timer run for the first time, schedule it again.
This PR completes the fix introduced in #8694.
Full changelog
true.