fix(balancer) start only needed upstream update timers #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-ball
approved these changes
May 24, 2022
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
Cherry-picked from #12305 This commit introduces a brand new implementation of the DNS client for Kong. Key features and improvements: - Designed for easy maintenance and troubleshooting - Follows industry norms - Utilizes `lua-resty-mlcache` for cross-worker DNS result caching - Implements stale-while-updating and stale-if-error behaviors - Improves responsiveness and reduces resolver traffic, especially with many workers The new DNS client is enabled by default. To use the old client, set `legacy_dns_client = on` in `kong.conf`. KAG-3220 --------- Co-authored-by: Keery Nie <[email protected]> Co-authored-by: Aapo Talvensaari <[email protected]> Co-authored-by: Thijs Schreijer <[email protected]> Co-authored-by: Chrono <[email protected]> Co-authored-by: Qi <[email protected]> Co-authored-by: Thibault Charbonnier <[email protected]> Co-authored-by: Datong Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Kong is using
worker_consistency = eventual, a timer is used to update the internal balancer state on everyworker_state_update_frequencyseconds. Instead of using the same timer for all changes, the said timer was being started again on every balancer update, the previous ones were kept running, piling up the number of timers.Full changelog
runloop/balancer.FTI-3274