fix(ldap-auth) use username, password for cache key #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashiranjan84
force-pushed
the
fix/ldap-negative-cache
branch
from
68bd02d to
f24eb72
Compare
thibaultcha
referenced
this pull request
Aug 7, 2018
- Remove negative caching as there is no way for invalidation - Use `%` instead of `bin.mod`
thibaultcha
reviewed
Aug 7, 2018
| @@ -28,29 +27,36 @@ for _, strategy in helpers.each_strategy() do | |||
| ldap_port = "389", | |||
| start_tls = false, | |||
| base_dn = "ou=scientists,dc=ldap,dc=mashape,dc=com", | |||
| attribute = "uid" | |||
| attribute = "uid", | |||
| cache_ttl = 5, | |||
There was a problem hiding this comment.
Could we use a slightly shorter TTL, to avoid slowing down our tests? 5s isn't much, but when every single test relying on TTL behaviour in the suite waits for 5s between each test, we end up with a problem... Maybe 1? 2?
There was a problem hiding this comment.
sure, will update it.
There was a problem hiding this comment.
I set it to one, please review
This change adds password as part of cache key, doing so we can cache invalid credential without blocking valid credential
shashiranjan84
force-pushed
the
fix/ldap-negative-cache
branch
from
f24eb72 to
3a63b47
Compare
thibaultcha
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds password as part of cache key, doing so
we can cache invalid credential without blocking valid credential
Full changelog