Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ldap-auth) remove bin.mod and negative cache #3618

Merged
merged 1 commit into from
Jul 13, 2018
Merged

fix(ldap-auth) remove bin.mod and negative cache #3618

merged 1 commit into from
Jul 13, 2018

Conversation

shashiranjan84
Copy link
Contributor

@shashiranjan84 shashiranjan84 commented Jul 13, 2018 •
edited
Loading

This PP fixes two issues with plugin:

  • One where request added negative cache for incorrect password.
  • Second when request results in 500 when very long password being used. Now % used instead of bin.mod as bin.mod does not exist

@shashiranjan84 shashiranjan84 requested review from akasetty and a team July 13, 2018 00:30
fix(ldap-auth) remove bin.mod and negative cache
3854e5a 
- Remove negative caching as there is no way for invalidation
- Use `%` instead of `bin.mod`
@hishamhm
Copy link
Contributor

@shashiranjan84 changes and regression tests look good! CI failure was unrelated, I restarted it. Will merge when we get the green light from Travis!

hishamhm
hishamhm approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@hishamhm hishamhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just waiting for CI.

@hishamhm hishamhm merged commit 5c53051 into master Jul 13, 2018
@hishamhm hishamhm deleted the fix/ldap-auth branch July 13, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamhm hishamhm hishamhm approved these changes

@akasetty akasetty Awaiting requested review from akasetty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashiranjan84 @hishamhm