chore(plugins): cherry pick batch queue return value fix to 3.1.x #10126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#10044) The log function in Datadog is called by the batch queue when a batch is processed, and batch queue relys on the return value of the callback. The return value of log function in Datadog always return `nil`, this makes batch queue consider the result of processing as failed. In this commit, the correct return value indicating the success in processing to fix this bug.
github-actions
bot
added
changelog
plugins/datadog
plugins/opentelemetry
plugins/statsd
labels
windmgc
changed the title
hanshuebner
approved these changes
Jan 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick the batch queue return value fix to 3.1.x branch.
PRs that have been cherry-picked:
Checklist
Full changelog
Issue reference
Fix #[issue number]