fix(plugins/datadog): add return value for log function in batch queue #10044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cannot find a way to write a test case for this pr. |
queue when a batch is scheduled to be processed, and batch queue relys on the return value of the process it holds. The return value of log function in datadog always return nil, this makes batch queue consider the result of processing is failed. In this pr, a return value is added to fix this bug. FTI 4645
liverpool8056
force-pushed
the
plugins/add-return-value-in-datadog
branch
from
186a9f8 to
0ed7efe
Compare
chronolaw
changed the title
chronolaw
reviewed
Jan 4, 2023
chronolaw
approved these changes
Jan 4, 2023
|
Found a way to add a test case with the helps of @windmgc . |
|
Waiting for tests as @liverpool8056 indicated. |
windmgc
approved these changes
Jan 4, 2023
Merged
3 tasks
rspurgeon
reviewed
Jan 6, 2023
CHANGELOG.md
Outdated
| @@ -103,6 +103,8 @@ | |||
| [#9877](https://github.com/Kong/kong/pull/9877) | |||
| - **JWT**: Deny requests that have different tokens in the jwt token search locations. Thanks Jackson 'Che-Chun' Kuo from Latacora for reporting this issue. | |||
| [#9946](https://github.com/Kong/kong/pull/9946) | |||
| - **Datadog**: Fix a bug that the batch queue in datadog can't get the right result when processing batch entries produced by datadog. | |||
There was a problem hiding this comment.
Let's make this text match what's in the StatsD PR
dndx
approved these changes
Jan 6, 2023
windmgc
pushed a commit
that referenced
this pull request
Jan 17, 2023
#10044) The log function in Datadog is called by the batch queue when a batch is processed, and batch queue relys on the return value of the callback. The return value of log function in Datadog always return `nil`, this makes batch queue consider the result of processing as failed. In this commit, the correct return value indicating the success in processing to fix this bug.
3 tasks
hanshuebner
pushed a commit
that referenced
this pull request
Jan 17, 2023
…0126) * fix(plugins/datadog): add return value for log function in batch queue (#10044) The log function in Datadog is called by the batch queue when a batch is processed, and batch queue relys on the return value of the callback. The return value of log function in Datadog always return `nil`, this makes batch queue consider the result of processing as failed. In this commit, the correct return value indicating the success in processing to fix this bug. * fix(plugins/statsd & opentelemetry): add return values for batch queue callback functions (#10052) Add return values for functions that will be processed in batch queue for these two plugins. Batch queue considers the result of processing unsuccessful without a return value, resulting the batch being reprocessed incorrectly. FTI-4645 Co-authored-by: Robin Xiang <[email protected]>
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
It is one of the serial refactors of helpers.lua https://konghq.atlassian.net/browse/KAG-5233 Cherry-picked from #13539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(plugins/datadog): The log function in datadog is called in batch queue when a batch is scheduled to be processed, and batch queue relys on the return value of the process it holds. The return value of log function in datadog always return nil, this makes batch queue consider the result of processing is failed. In this pr, a return value is added to fix this bug.
Checklist
Issue reference
FTI-4645