feat: Ability to limit request size and connection count #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RudraniW
changed the title
weissi
reviewed
Aug 20, 2019
| @@ -660,3 +673,23 @@ enum KituraWebSocketUpgradeError: Error { | |||
| // Unknown upgrade error | |||
| case unknownUpgradeError | |||
| } | |||
|
|
|||
| class Atomic<A> { | |||
There was a problem hiding this comment.
you could use NIO's Atomic which actually is atomic and doesn't require a lock. Just add NIOConcurrencyHelpers to Package.swift and import NIOConcurrencyHelpers
|
I am closing this PR as I have implemented the other approach to limit request size and connection count in #222 . |
2 tasks
added 7 commits
September 4, 2019 14:48
RudraniW
force-pushed
the
requestSize
branch
from
2232cbf to
118c5c5
Compare
djones6
added a commit
to Kitura/Kitura
that referenced
this pull request
Sep 5, 2019
djones6
suggested changes
Sep 5, 2019
added 7 commits
September 12, 2019 13:52
djones6
reviewed
Sep 26, 2019
djones6
reviewed
Sep 26, 2019
djones6
reviewed
Sep 26, 2019
| @@ -80,13 +80,15 @@ class LargePayloadTests: KituraNetTest { | |||
|
|
|||
| func handle(request: ServerRequest, response: ServerResponse) { | |||
| if request.method.uppercased() == "GET" { | |||
| print("hello world") | |||
There was a problem hiding this comment.
These print statements probably want to be removed?
djones6
reviewed
Sep 26, 2019
djones6
reviewed
Sep 26, 2019
djones6
reviewed
Sep 26, 2019
djones6
reviewed
Sep 26, 2019
| @@ -309,15 +324,16 @@ public class HTTPServer: Server { | |||
| } | |||
| .childChannelInitializer { channel in | |||
| let httpHandler = HTTPRequestHandler(for: self) | |||
| let config: NIOHTTPServerUpgradeConfiguration = (upgraders: upgraders, completionHandler: { _ in | |||
| let config: HTTPUpgradeConfiguration = (upgraders: upgraders, completionHandler: { ctx in | |||
| self.ctx = ctx | |||
There was a problem hiding this comment.
Does this new property ctx ever get read? I can't see reference to it elsewhere in this PR
djones6
reviewed
Sep 26, 2019
|
@djones6 Thanks for your feedback. |
djones6
added a commit
to Kitura/Kitura
that referenced
this pull request
Oct 7, 2019
djones6
reviewed
Oct 7, 2019
djones6
reviewed
Oct 7, 2019
djones6
reviewed
Oct 7, 2019
djones6
changed the title
djones6
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows a requestSizeLimit (maximum bytes for a request, including the header size) and connectionLimit (total number of concurrent connections) to be configured when registering a server.
Example usage:
let serverConfig = HTTPServerConfiguration(requestSizeLimit: 1024, connectionLimit: 1024)If you do not specify either of the parameters, or do not specify a
HTTPServerConfigurationat all, then default values are used. The defaults are defined inHTTPServerConfigurationin Kitura-NIO here: https: //github.com/RudraniW/Kitura-NIO/blob/requestSize/Sources/KituraNet/HTTP/HTTPServerConfiguration.swiftMotivation and Context
See: #206 and Kitura/Kitura#1384