Build urlURL using URLComponents #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 66.71% 66.84% +0.12%
==========================================
Files 20 20
Lines 1298 1300 +2
==========================================
+ Hits 866 869 +3
+ Misses 432 431 -1
Continue to review full report at Codecov.
|
Closed
pushkarnk
suggested changes
Jan 21, 2019
|
|
||
| _urlComponents?.port = Int(localAddressPort) | ||
|
|
||
| let uriComponents = _urlString.components(separatedBy: "?") |
There was a problem hiding this comment.
It may be better to use String.split() here. See Kitura/Kitura-net#287
| _urlComponents?.port = Int(localAddressPort) | ||
|
|
||
| let uriComponents = _urlString.components(separatedBy: "?") | ||
| if uriComponents.count > 0 { |
There was a problem hiding this comment.
This check may not be necessary.
There was a problem hiding this comment.
I'm sorry, this check will be needed if we use String.split(separator:)
|
I just rebased this on the latest master to make sure Kitura tests are run. |
pushkarnk
approved these changes
Jan 26, 2019
|
Kitura tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all Kitura failures reported in #154